From: Liam Girdwood <lrg@ti.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 3/3] ASoC: Tegra: Implement SPDIF CPU DAI
Date: Mon, 4 Jul 2011 11:10:48 +0100 [thread overview]
Message-ID: <4E1191A8.3070000@ti.com> (raw)
In-Reply-To: <20110702191607.GA10505@opensource.wolfsonmicro.com>
On 02/07/11 20:16, Mark Brown wrote:
> On Fri, Jul 01, 2011 at 01:56:15PM -0600, Stephen Warren wrote:
>
>> +struct snd_soc_dai_driver tegra_spdif_dai = {
>> + .name = DRV_NAME ".0",
>
> This looks wrong - what's with the .0? If there can be only one device
> there should be no number, if there can be multiple devices hard coding
> is bad karma. Either way the number should come from the instantiation.
After this comment has been fixed.
Acked-by: Liam Girdwood <lrg@ti.com>
next prev parent reply other threads:[~2011-07-04 10:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 19:56 [PATCH 0/3] ASoC: Tegra: Fixes and SPDIF support Stephen Warren
[not found] ` <1309550175-30551-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-07-01 19:56 ` [PATCH 1/3] ASoC: Tegra: I2S: Ensure clock is enabled when writing regs Stephen Warren
2011-07-01 19:56 ` [PATCH 2/3] ASoC: Tegra: I2S: s/clk_get_sys/clk_get/ Stephen Warren
2011-07-01 19:56 ` [PATCH 3/3] ASoC: Tegra: Implement SPDIF CPU DAI Stephen Warren
[not found] ` <1309550175-30551-4-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-07-02 19:16 ` Mark Brown
2011-07-04 10:10 ` Liam Girdwood [this message]
2011-07-04 15:50 ` [PATCH 0/3] ASoC: Tegra: Fixes and SPDIF support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1191A8.3070000@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox