From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 3/3] arm/dt: tegra: add dts file for paz00 Date: Tue, 25 Oct 2011 14:51:40 -0500 Message-ID: <4EA7134C.3050102@gmail.com> References: <90ee88bcde84141e0280ffa4ccbd288462489eba.1319313020.git.marvin24@gmx.de> <74CDBE0F657A3D45AFBB94109FB122FF173E1B4189@HQMAIL01.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF173E1B4189-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Marc Dietrich , "Grant Likely (grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org)" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Colin Cross List-Id: linux-tegra@vger.kernel.org On 10/25/2011 12:16 AM, Stephen Warren wrote: > Marc Dietrich wrote at Saturday, October 22, 2011 2:17 PM: >> * NOT FOR COMMIT * >> >> This just adds the dts for paz00. I like to add it to board-dt as >> well as soon as I find out which tree to base it on. > ... >> +++ b/arch/arm/boot/dts/tegra-paz00.dts > > One thing that cross my mind when writing the TrimSlice support and I > forgot to mention: Should these files be named ${soc}-${board}.dts or > ${vendor}-${board}.dts (tegra-paz00.dts or toshiba-paz00.dts or > compal-paz00.dts). I'm OK either way; just want to follow any outside > expectations. > >> @@ -0,0 +1,51 @@ >> +/dts-v1/; >> + >> +/memreserve/ 0x1c000000 0x04000000; >> +/include/ "tegra20.dtsi" >> + >> +/ { >> + model = "Toshiba AC100 / Dynabook AZ"; >> + compatible = "compal,paz00", "nvidia,tegra20"; >> + >> + chosen { >> + bootargs = "console=ttyS0,115200n8 root=/dev/mmcblk1p1"; >> + }; >> + >> + memory@0 { > > The other boards just have "memory" here; which is wrong? > Both... I believe it should be "memory@". Rob