From: Varun Wadekar <vwadekar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Kim Phillips <kim.phillips-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"herbert-F6s6mLieUQo7FNHlEwC/lvQIK84fMopw@public.gmane.org"
<herbert-F6s6mLieUQo7FNHlEwC/lvQIK84fMopw@public.gmane.org>,
"davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org"
<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v1] crypto: driver for tegra AES hardware
Date: Wed, 16 Nov 2011 14:35:00 +0530 [thread overview]
Message-ID: <4EC37CBC.4060806@nvidia.com> (raw)
In-Reply-To: <20111116025720.27e6b710e8b333612862bb2e-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> it's not - it saves writes.
Are you ok with this solution? Either way I wan to start with a clear
key table before programming the hardware.
> why do you need to clear the entire key table if it will be
> overwritten anyway?
If you set a > 128-bit key and then set a 128-bit key, the remaining
bits still remain in the key table. Similarly, if we use updated IV in
one operation and want to use the initial IV for the next, the updated
IV will still remain in the key table. The entire key table is copied to
the AES engine. Even though, we program the engine with the exact number
of bits to use for the key and whether to use the updated/initial IV, I
feel its better if the unused bits are zero instead of having garbage.
next prev parent reply other threads:[~2011-11-16 9:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 10:42 [PATCH v1] crypto: driver for tegra AES hardware vwadekar
[not found] ` <1320489734-9085-1-git-send-email-vwadekar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-05 23:10 ` Kim Phillips
[not found] ` <20111105181025.69918e625a169ccb30d9b7c8-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-11-12 10:22 ` Varun Wadekar
[not found] ` <4EBE48E8.60205-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-14 17:26 ` Stephen Warren
2011-11-14 19:13 ` Kim Phillips
2011-11-15 4:10 ` Varun Wadekar
[not found] ` <4EC1E642.2090309-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-15 16:10 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF1740805D40-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2011-11-16 7:14 ` Varun Wadekar
[not found] ` <4EC362EA.3020204-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-16 8:57 ` Kim Phillips
[not found] ` <20111116025720.27e6b710e8b333612862bb2e-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-11-16 9:05 ` Varun Wadekar [this message]
[not found] ` <4EC37CBC.4060806-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-16 9:17 ` Kim Phillips
[not found] ` <20111116031703.e006c81ebf5368365e7a22fb-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2011-11-16 12:28 ` Varun Wadekar
[not found] ` <4EC3AC7D.4080705-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-11-17 11:29 ` Varun Wadekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC37CBC.4060806@nvidia.com \
--to=vwadekar-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=herbert-F6s6mLieUQo7FNHlEwC/lvQIK84fMopw@public.gmane.org \
--cc=kim.phillips-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox