From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/6] ASoC: Allow device tree to specify a card's name Date: Wed, 07 Dec 2011 18:15:55 -0600 Message-ID: <4EE001BB.7010808@gmail.com> References: <1323296033-28730-1-git-send-email-swarren@nvidia.com> <1323296033-28730-3-git-send-email-swarren@nvidia.com> <20111207235818.GB12945@quad.lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111207235818.GB12945-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olof Johansson Cc: Stephen Warren , Colin Cross , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, segher-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 12/07/2011 05:58 PM, Olof Johansson wrote: > On Wed, Dec 07, 2011 at 03:13:41PM -0700, Stephen Warren wrote: >> If a card's device was instantiated from device tree, and the device tree >> has a "user-visible-name" property, use that as the card's name. >> >> Signed-off-by: Stephen Warren >> --- >> v2: New patch implementing new functionality >> >> Re: the binding documentation: >> * "SoC" here refers to the fact this is a binding oriented at System-on- >> chip audio complexes, rather than having to do with "ASoC"; both names >> were derived from the same root. >> * Do we need a compatible property for this "base class" binding at all? >> I think it's a good idea, even though the code doesn't actually rely >> on it. >> * Should the vendor field in the compatible property be "generic", >> "linux", or absent? I've tried to make these bindings generic and >> applicable to other OSs, so "linux," seems wrong. > > Just drop "generic," in my opinion. Rob? Grant? Segher? I think the whole string should be dropped as it is too generic. Rob > >> * Should the property "user-visible-name" have a "generic," prefix or >> similar? > > The root node uses "model" for the same purpose, to describe the machine > model with a user-visible string. Maybe just use that name here? > > > -Olof