Re: [PATCH V1] regulator: tps65910: Sleep control through external inputs

[Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On Tuesday 24 January 2012 05:54 PM, Mark Brown wrote:
> On Tue, Jan 24, 2012 at 05:49:52PM +0530, Laxman Dewangan wrote:
> The external controls for different rails are managed by power
>> manament driver of soc in kernel to toggel them. The bootloader make
>> sure that all external control signals are active just before
>> jumping into kernel so that there is no issue during regulator init.
>> When system reboots in kernel by kernel command, the configuration
>> of the pmu still maintain as what it was in kernel before reboot and
>> issue  system reboots. There is possibility that the default (POR)
>> of these control signals are not active on soc reset or initial
>> stage of the bootloader and hence it can turn off the rails which
>> can avoid system booting.
>> So kernel need to remove all external controls before reboot system.
> The code needs to explain this stuff so readers will know.
>
Will add this information in code.
>
>> Hmm.., I thought that  suspend mode apis manages the low/full-on
>> power mode when the controls are not through external inputs. There
>> is different register for configuring the power mode by i2c- write.
>> This macro help in configuration of mode when enabled with external
>> controls which configures in different sets of register.
> No, usually it's used for configuring suspend mode when the PMIC knows
> about system suspend.
>
Ok, will move this configuration with the  suspend mode and program the 
correct register based on external signals.

> I used this member in the probe as for configuring the rails..
>> +        err = tps65910_set_ext_sleep_config(pmic, i,
>> +                pmic_plat_data->regulator_ext_sleep_control[i]);
> Right, but I can't see any code which manages the signals at runtime.
> You tell the device to use the signals but the signals aren't (as far as
> I can see) controlled by software.
I dont think we need to supply information that how EN1/EN2/EN3 toggles 
from external word?
This should be done on the consumer driver  for these rails to toggle 
the signals based on requirements.

E.g. If cpu power is in VDDCTRL rail and if DVFS mechanism of SOC wants 
that cpu rails to be ON, it will make the control signal active and if 
it wants to disable the rail then it will deactivate it.
The toggling of the control lines depends on how the power management 
controller is designed for a given SOC and how it manages.




> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html