From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v4 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot Date: Wed, 29 Feb 2012 13:21:16 -0700 Message-ID: <4F4E88BC.4070106@nvidia.com> References: <1330536689-9121-5-git-send-email-sjg@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1330536689-9121-5-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Simon Glass Cc: U-Boot Mailing List , Tom Warren , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Jerry Van Baren , Devicetree Discuss , Heiko Schocher List-Id: linux-tegra@vger.kernel.org On 02/29/2012 10:31 AM, Simon Glass wrote: > Add U-Boot's peripheral clock information to the Tegra20 device tree file. > diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi > compatible = "nvidia,tegra20-i2c"; > reg = <0x7000C000 0x100>; > interrupts = < 70 >; > + clocks = <&tegra_car 12>; /* PERIPH_ID_I2C1 */ > }; The I2C modules all require 2 clocks; the one you've added in this patch and a second reference to pll_p_out3. Can you please list both of these here, and update the I2C binding to describe the set of clocks that it requires. Thanks. -- nvpublic