From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: U-Boot Mailing List
<u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>,
Tom Warren <twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Yen Lin <yelin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Heiko Schocher <hs-ynQEQJNshbs@public.gmane.org>
Subject: Re: [PATCH v5 5/9] tegra: i2c: Add I2C driver
Date: Wed, 07 Mar 2012 13:46:47 -0700 [thread overview]
Message-ID: <4F57C937.7090108@wwwdotorg.org> (raw)
In-Reply-To: <1331096428-6317-6-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
On 03/06/2012 10:00 PM, Simon Glass wrote:
> From: Yen Lin <yelin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> Add basic i2c driver for Tegra2 with 8- and 16-bit address support.
> The driver requires CONFIG_OF_CONTROL to obtain its configuration
> from the device tree.
>
> (Simon Glass: sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org modified for upstream)
>
> Signed-off-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
I'm not sure whether i2c_init_board() correctly detects I2C bus ID
assignment conflicts between nodes with the "-i2c" and "-i2c-dvc"
compatible values, but I think that only affects cases where the .dts
file is already wrong, so it's probably not a big deal.
Aside from that, I did a very very brief review. So,
Acked-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
next prev parent reply other threads:[~2012-03-07 20:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 5:00 [PATCH v5 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot Simon Glass
[not found] ` <1331096428-6317-5-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-03-07 5:00 ` [PATCH v5 5/9] tegra: i2c: Add I2C driver Simon Glass
[not found] ` <1331096428-6317-6-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-03-07 5:32 ` Heiko Schocher
2012-03-07 20:46 ` Stephen Warren [this message]
[not found] ` <4F57C937.7090108-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-08 6:32 ` Simon Glass
2012-03-07 20:39 ` [PATCH v5 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot Stephen Warren
[not found] ` <4F57C76D.6040004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-03-08 6:31 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F57C937.7090108@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=hs-ynQEQJNshbs@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=twarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
--cc=yelin-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox