From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 12/17] ASoC: tegra: utils: add support for Tegra30 devices Date: Sat, 31 Mar 2012 19:57:12 -0600 Message-ID: <4F77B5F8.8080205@wwwdotorg.org> References: <1333148852-17806-1-git-send-email-swarren@wwwdotorg.org> <1333148852-17806-13-git-send-email-swarren@wwwdotorg.org> <20120331202015.GN5012@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120331202015.GN5012-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Liam Girdwood , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/31/2012 02:20 PM, Mark Brown wrote: > On Fri, Mar 30, 2012 at 05:07:27PM -0600, Stephen Warren wrote: > >> - ret = tegra_asoc_utils_init(&alc5632->util_data, &pdev->dev); >> + ret = tegra_asoc_utils_init(&alc5632->util_data, + >> TEGRA_ASOC_UTILS_SOC_TEGRA20, &pdev->dev); > > Would it not be more sensible to do cpu_is_() calls in the utils > code rather than have the board say? It'd possibly also end up > looking nicer in the code and may mean the compiler can figure out > not to include cases that can't be taken in the current build. We had floated the idea of adding cpu_is_*() (Well, soc_is_*()) macros for Tegra in the past, and received the message that was a bad idea; things should instead be driven by compatible flag values or similar. See http://www.spinics.net/lists/linux-tegra/msg02250.html. That said, I see many cpu_is_*() calls in arch/arm, so perhaps we should revisit this.