From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 04/11] gpio: tegra: Iterate over the correct number of banks Date: Wed, 04 Apr 2012 12:41:54 -0600 Message-ID: <4F7C95F2.2050808@wwwdotorg.org> References: <1333148404-17691-1-git-send-email-swarren@wwwdotorg.org> <1333148404-17691-5-git-send-email-swarren@wwwdotorg.org> <20120404175829.GD29919@quad.lixom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120404175829.GD29919-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olof Johansson Cc: Colin Cross , Linus Walleij , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Stephen Warren List-Id: linux-tegra@vger.kernel.org On 04/04/2012 11:58 AM, Olof Johansson wrote: > On Fri, Mar 30, 2012 at 04:59:57PM -0600, Stephen Warren wrote: >> From: Stephen Warren >> >> When Tegra30 support was added to the Tegra GPIO driver, a few places >> which iterated over all banks were not converted to use the variable >> tegra_gpio_bank_count rather than hard-coding the bank count. Fix this. >> >> Signed-off-by: Stephen Warren > > Acked-by: Olof Johansson > > Should this be fixed in 3.4 as well? Given the need for some of the other > patches in this series I suppose gpio isn't really working on tegra30 there > though, so it's not technically a regression... It's probably not a bad idea, even if we don't expect many users; the code may as well be correct. I assume since 3.4 is still in the rc stage, I would send an explicit pull request to arm-soc for that rather than just Cc: stable. I wonder if "gpio: tegra: fix register address calculations for Tegra30" shouldn't be applied (after addressing your comments) for 3.4 too? It might be a little large of a change?