From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Benoit Goby <benoit-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
USB list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Changes to power management in ehci-tegra
Date: Thu, 12 Apr 2012 12:26:32 -0600 [thread overview]
Message-ID: <4F871E58.8020108@wwwdotorg.org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1204121401360.1496-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
On 04/12/2012 12:07 PM, Alan Stern wrote:
> Benoit or anyone else:
>
> Right now the ehci-tegra driver powers down the EHCI controller during
> bus suspend, if the appropriate parameter is set. This is not the
> right thing to do, and it will break under some newly added changes to
> the USB core.
>
> Instead, the driver should leave the controller powered up during bus
> suspend, and power it down during controller suspend. Below is a patch
> that attempts to do this.
>
> I have no way to test this patch; I haven't even compiled it. Please
> see if it works okay, or if it needs to be fixed at all.
I can test this. How would I trigger the bus conditions this patch
affects? Note that we don't have system suspend on Tegra yet.
next prev parent reply other threads:[~2012-04-12 18:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 18:07 Changes to power management in ehci-tegra Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204121401360.1496-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-12 18:26 ` Stephen Warren [this message]
[not found] ` <4F871E58.8020108-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-12 18:45 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204121437300.1496-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-13 18:51 ` Stephen Warren
[not found] ` <4F8875BE.5010202-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-13 19:46 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204131541190.1146-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-13 20:07 ` Stephen Warren
[not found] ` <4F88879D.9020406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-13 21:00 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204131640120.1166-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-16 20:37 ` Stephen Warren
[not found] ` <4F8C82FD.2030600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-17 14:56 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204171050380.1364-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-17 23:28 ` Stephen Warren
[not found] ` <4F8DFC8C.5010001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-18 15:22 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204181102250.1548-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-18 18:24 ` Stephen Warren
[not found] ` <4F8F06F6.2040503-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-18 20:40 ` Alan Stern
2012-04-18 19:31 ` Stephen Warren
[not found] ` <4F8F16A6.9040801-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-18 20:47 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204181640550.1149-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-18 21:45 ` Stephen Warren
[not found] ` <4F8F3608.5030005-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-19 13:52 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204190948580.2070-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-19 18:23 ` Stephen Warren
[not found] ` <4F90581A.70109-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-19 19:01 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204191457160.1154-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-19 19:22 ` Stephen Warren
[not found] ` <4F90660E.1050508-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-04-19 19:45 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1204191535350.1154-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-04-19 19:52 ` Stephen Warren
2012-04-19 9:25 ` Alex Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F871E58.8020108@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=benoit-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox