From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: Changes to power management in ehci-tegra Date: Thu, 12 Apr 2012 12:26:32 -0600 Message-ID: <4F871E58.8020108@wwwdotorg.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Stern Cc: Benoit Goby , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, USB list List-Id: linux-tegra@vger.kernel.org On 04/12/2012 12:07 PM, Alan Stern wrote: > Benoit or anyone else: > > Right now the ehci-tegra driver powers down the EHCI controller during > bus suspend, if the appropriate parameter is set. This is not the > right thing to do, and it will break under some newly added changes to > the USB core. > > Instead, the driver should leave the controller powered up during bus > suspend, and power it down during controller suspend. Below is a patch > that attempts to do this. > > I have no way to test this patch; I haven't even compiled it. Please > see if it works okay, or if it needs to be fixed at all. I can test this. How would I trigger the bus conditions this patch affects? Note that we don't have system suspend on Tegra yet.