From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support Date: Tue, 17 Apr 2012 16:35:09 -0600 Message-ID: <4F8DF01D.9040900@wwwdotorg.org> References: <1334645155-13799-1-git-send-email-ldewangan@nvidia.com> <1334645155-13799-4-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1334645155-13799-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan , olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org Cc: Colin Cross , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 04/17/2012 12:45 AM, Laxman Dewangan wrote: > Add the device info for ALS and proximity sensor isl29018. (There were a ton of irrelevant people CC'd on this patch; I cut them out, but kept the lists in case anyone was interested in the replies. The most relevant list, linux-tegra, also wasn't CC'd) > diff --git a/arch/arm/boot/dts/tegra-ventana.dts b/arch/arm/boot/dts/tegra-ventana.dts > + /* ALS and proximity sensor */ > + isl29018: isl29018@44 { I don't think the label "isl29018:" serves any purpose; nothing else needs to refer to this node. I note from http://patchwork.ozlabs.org/patch/132936/ that: a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you please comment here? b) There's an interrupt signal connected to the device. Can you please add that, irrespective of whether the driver uses it. c) This device is also present on Seaboard. Can you update tegra-seaboard.dts too? You can find the relevant bus from the link above. Thanks. > + compatible = "isl,isl29018"; > + reg = <0x44>; > + }; > }; > > i2c@7000c400 {