Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support

Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support

[Stephen Warren]

On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
> Add the device info for ALS and proximity sensor isl29018.

(There were a ton of irrelevant people CC'd on this patch; I cut them
out, but kept the lists in case anyone was interested in the replies.
The most relevant list, linux-tegra, also wasn't CC'd)

> diff --git a/arch/arm/boot/dts/tegra-ventana.dts b/arch/arm/boot/dts/tegra-ventana.dts

> +		/* ALS and proximity sensor */

> +		isl29018: isl29018@44 {

I don't think the label "isl29018:" serves any purpose; nothing else
needs to refer to this node.

I note from http://patchwork.ozlabs.org/patch/132936/ that:

a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
please comment here?

b) There's an interrupt signal connected to the device. Can you please
add that, irrespective of whether the driver uses it.

c) This device is also present on Seaboard. Can you update
tegra-seaboard.dts too? You can find the relevant bus from the link above.

Thanks.

> +			compatible = "isl,isl29018";
> +			reg = <0x44>;
> +		};
>  	};
>  
>  	i2c@7000c400 {

Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support

[Laxman Dewangan]

On Wednesday 18 April 2012 04:05 AM, Stephen Warren wrote:
> On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
>> Add the device info for ALS and proximity sensor isl29018.
>> +		isl29018: isl29018@44 {
> I don't think the label "isl29018:" serves any purpose; nothing else
> needs to refer to this node.
>
> I note from http://patchwork.ozlabs.org/patch/132936/ that:
>
> a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
> please comment here?

> b) There's an interrupt signal connected to the device. Can you please
> add that, irrespective of whether the driver uses it.
>

Will do.
> c) This device is also present on Seaboard. Can you update
> tegra-seaboard.dts too? You can find the relevant bus from the link above.
>
Will do.


I will wait for finalizing the vendor prefix before creating the next patch.
This will impact the driver also.

Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support

[Laxman Dewangan]

On Wednesday 18 April 2012 04:05 AM, Stephen Warren wrote:
> On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
>> Add the device info for ALS and proximity sensor isl29018.
>
> a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
> please comment here?
>

Any comments on this? I think "isil" is good as it is the symbol in 
nasdaq also: Intersil Corporation (ISIL).
If no objection than I can send my next version of patch ;)

Adding LinusW, Mark and Grant if they have any comment here.

Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support

[Stephen Warren]

On 04/19/2012 03:12 AM, Laxman Dewangan wrote:
> On Wednesday 18 April 2012 04:05 AM, Stephen Warren wrote:
>> On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
>>> Add the device info for ALS and proximity sensor isl29018.
>>
>> a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
>> please comment here?
> 
> Any comments on this? I think "isil" is good as it is the symbol in
> nasdaq also: Intersil Corporation (ISIL).
> If no objection than I can send my next version of patch ;)

Yes, the idea is to use stock ticker symbols where possible, so it
sounds like isil is the way to go.

Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support

[Linus Walleij]

On Thu, Apr 19, 2012 at 11:12 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> On Wednesday 18 April 2012 04:05 AM, Stephen Warren wrote:
>>
>> On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
>>>
>>> Add the device info for ALS and proximity sensor isl29018.
>>
>>
>> a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
>> please comment here?
>>
>
> Any comments on this? I think "isil" is good as it is the symbol in nasdaq
> also: Intersil Corporation (ISIL).
> If no objection than I can send my next version of patch ;)
>
> Adding LinusW, Mark and Grant if they have any comment here.

Like most of the kernel people I don't care much about that as long
as the string is unique ... your pick is likely the best.

Linus Walleij

Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support

[Olof Johansson]

On Tue, Apr 17, 2012 at 04:35:09PM -0600, Stephen Warren wrote:
> On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
> > Add the device info for ALS and proximity sensor isl29018.
> 
> (There were a ton of irrelevant people CC'd on this patch; I cut them
> out, but kept the lists in case anyone was interested in the replies.
> The most relevant list, linux-tegra, also wasn't CC'd)
> 
> > diff --git a/arch/arm/boot/dts/tegra-ventana.dts b/arch/arm/boot/dts/tegra-ventana.dts
> 
> > +		/* ALS and proximity sensor */
> 
> > +		isl29018: isl29018@44 {
> 
> I don't think the label "isl29018:" serves any purpose; nothing else
> needs to refer to this node.
> 
> I note from http://patchwork.ozlabs.org/patch/132936/ that:
> 
> a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
> please comment here?

The standard practice is to use stock tickers, but if companies aren't public
then there isn't much you can do. Like Linus said, use your best judgement and
taste and that's really all we can ask for. :)



-Olof