[PATCH] USB: ehci-tegra: don't call set_irq_flags(IRQF_VALID)

[PATCH] USB: ehci-tegra: don't call set_irq_flags(IRQF_VALID)

[Stephen Warren]

From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

This call is not needed; the IRQ controller should (and does) set up
interrupts correctly. set_irq_flags() isn't exported to modules, to
this also fixes compilation of ehci-tegra.c as a module.

Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 drivers/usb/host/ehci-tegra.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 14532fe..10bb3ea 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -733,7 +733,6 @@ static int tegra_ehci_probe(struct platform_device *pdev)
 		err = -ENODEV;
 		goto fail;
 	}
-	set_irq_flags(irq, IRQF_VALID);
 
 #ifdef CONFIG_USB_OTG_UTILS
 	if (pdata->operating_mode == TEGRA_USB_OTG) {
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] USB: ehci-tegra: don't call set_irq_flags(IRQF_VALID)

[Greg KH]

On Wed, Apr 18, 2012 at 02:43:40PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> This call is not needed; the IRQ controller should (and does) set up
> interrupts correctly. set_irq_flags() isn't exported to modules, to
> this also fixes compilation of ehci-tegra.c as a module.

So this is needed for the 3.4-final release, right?

greg k-h

Re: [PATCH] USB: ehci-tegra: don't call set_irq_flags(IRQF_VALID)

[Stephen Warren]

On 04/18/2012 03:01 PM, Greg KH wrote:
> On Wed, Apr 18, 2012 at 02:43:40PM -0600, Stephen Warren wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> This call is not needed; the IRQ controller should (and does) set up
>> interrupts correctly. set_irq_flags() isn't exported to modules, to
>> this also fixes compilation of ehci-tegra.c as a module.
> 
> So this is needed for the 3.4-final release, right?

Yes. I haven't tested it anywhere than next-20120416, but I believe it
is applicable and should work anywhere the patch applies.