From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/1] ARM: tegra: Add Tegra Memory Controller(MC) driver Date: Thu, 03 May 2012 12:39:00 -0600 Message-ID: <4FA2D0C4.4020608@wwwdotorg.org> References: <1336063897-12083-1-git-send-email-hdoyu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1336063897-12083-1-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hiroshi DOYU , Olof Johansson , Russell King , Arnd Bergmann Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Colin Cross , Grant Likely , Rob Herring , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 05/03/2012 10:51 AM, Hiroshi DOYU wrote: > Tegra Memory Controller(MC) driver for Tegra20/30. > Added to support MC General interrupts, mainly for IOMMU. > The location of a file may not be suitable because of xxx_driver under arch/arm/mach-*. > --- > diff --git a/arch/arm/mach-tegra/Makefile b/arch/arm/mach-tegra/Makefile Russell, Olof, Arnd, Where should this driver be placed? It's a completely Tegra-specific module, and I don't believe there's any drivers/ directory or other subsystem that's appropriate to house it right now. Should we go ahead and create a drivers/arm/ for this? Perhaps drivers/misc/? Honestly, to me it seems best to keep purely platform-specific drivers like this in arch/arm/mach-tegra, since that's the most closely Tegra-related directory. Hiroshi, This driver attempts to cover both Tegra20 and Tegra30. However, there's almost no common code. I think it'd be best as separate tegra20-mc.c and tegra30-mc.c. This patch should include DT binding documentation. That all said, I'd hold off on reposting this until we work out how the MC/GART/SMMU parent-child relationship stuff is worked out; see my immediately previous email.