From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/3] ARM: dt: tegra: seaboard: add regulators Date: Mon, 25 Jun 2012 09:12:35 -0600 Message-ID: <4FE87FE3.1080608@wwwdotorg.org> References: <1340406842-27135-1-git-send-email-swarren@wwwdotorg.org> <4FE80413.6070001@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FE80413.6070001-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: Olof Johansson , Colin Cross , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen Warren , Mark Brown List-Id: linux-tegra@vger.kernel.org On 06/25/2012 12:24 AM, Laxman Dewangan wrote: > On Saturday 23 June 2012 04:44 AM, Stephen Warren wrote: >> From: Stephen Warren >> >> Seaboard uses a TPS6586x regulator. Instantiate this, and hook up a >> couple of fixed GPIO-controlled regulators too. >> >> The regulator configurations were mostly taken from the ChromeOS 3.2 >> kernel. Exceptions are: >> >> * The schematic lists a fixed voltage for each rail, whereas the ChromeOS >> kernel lists a range for many rails. I used the values from the >> ChromeOS >> kernel in all cases, since I know the board file there is the most >> complete available for this hardware. >> >> * The vdd_1v2 fixed regulator is present only in the schematic. So, I >> added >> this based on the schematic. >> >> * A 3.3v fixed regulator using GPIO3 of the TPS6586x is present in the >> ChromeOS kernel, but not in the schematic. So, I dropped this based on >> the schematic. >> >> Signed-off-by: Stephen Warren >> --- > > Acked-by: Laxman Dewangan > > I think this series very much depends on the series > [PATCH V3 0/3] regulator: dt: add policy to match regulator with prop > "regulator-compatible" That's certainly true. However, it's a runtime dependency to enable a new feature, and shouldn't cause any breakage without that patch, so we don't need to be explicit about the dependency in git. >> + regulator@3 { >> + reg =<3>; >> + regulator-compatible = "ldo0"; >> + regulator-name = "vdd_ldo0"; >> + regulator-min-microvolt =<1250000>; >> + regulator-max-microvolt =<3300000>; >> + vin-supply =<&sm2_reg>; > > I think support for vin-supply is still not there for this regulator in > driver. That's also true. I wonder if we shouldn't support this in the regulator core bindings instead, since the existence of a parent regulator seems likely to be common. Either way, I'd like to include the property to document it for now.