From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2 0/6] Port Tegra to generic clk framework Date: Tue, 03 Jul 2012 10:29:48 -0600 Message-ID: <4FF31DFC.8030708@wwwdotorg.org> References: <1341313761-22118-1-git-send-email-pgaikwad@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1341313761-22118-1-git-send-email-pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Prashant Gaikwad Cc: mturquette-l0cyMroinI0@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 07/03/2012 05:09 AM, Prashant Gaikwad wrote: > This patch set ports Tegra clock code to generic clock framework. > > Depends on > [PATCH v3 0/9] Add clk_prepare/clk_unprepare series > [PATCH] ARM: tegra: Remove second instance of uart clk > [PATCH] dma: tegra: add clk_prepare/clk_unprepare > [PATCH] ARM: tegra: dma: rename driver name for clock to "tegra-apbdma" > > Tested on Ventana and Cardhu > > v2: > - Rebased on Tegra's for-3.6/common-clk OK, this applies to for-3.6/common-clk without issue now. However, there are still runtime problems: On Tegra20(Ventana), running Tegra's for-next branch with these patches merged in, if I play audio, the sound is much too low a pitch; the I2S clock must be being set too low. Also, if I play the same file twice, once encoded as 48KHz once encoded as 44.1KHz, the pitch is different. On Tegra20(Ventana), running next-20120703 plus a few local patches for regulators plus these common clock patches, then I see the same segfaults during boot that I mentioned before. It seems something in linux-next not in Tegra's for-next branch is breaking the common clock code for us. Neither problem is seen on Cardhu with the same kernels. Can you please investigate and fix these issues? Thanks.