[PATCH] usb: host: tegra: pass correct pointer in ehci_setup()

[PATCH] usb: host: tegra: pass correct pointer in ehci_setup()

[Laxman Dewangan]

The ehci_setup() require the pointer of usb_hcd.
Passing the correct pointer in place of ehci_hcd
pointer.

This is side effetct of change:
commit 1a49e2ac9651df7349867a5cf44e2c83de1046af
Author: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>

    EHCI: centralize controller initialization


Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
 drivers/usb/host/ehci-tegra.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
index 9e44b1f..d2a7c95 100644
--- a/drivers/usb/host/ehci-tegra.c
+++ b/drivers/usb/host/ehci-tegra.c
@@ -285,7 +285,7 @@ static int tegra_ehci_setup(struct usb_hcd *hcd)
 	/* switch to host mode */
 	hcd->has_tt = 1;
 
-	retval = ehci_setup(ehci);
+	retval = ehci_setup(hcd);
 	if (retval)
 		return retval;
 
-- 
1.7.1.1

Re: [PATCH] usb: host: tegra: pass correct pointer in ehci_setup()

[Venu Byravarasu]

Acked-by: Venu Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Tested-by: Venu Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On Thursday 12 July 2012 02:06 PM, Laxman Dewangan wrote:
> The ehci_setup() require the pointer of usb_hcd.
> Passing the correct pointer in place of ehci_hcd
> pointer.
>
> This is side effetct of change:
> commit 1a49e2ac9651df7349867a5cf44e2c83de1046af
> Author: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
>
>      EHCI: centralize controller initialization
>
>
> Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>   drivers/usb/host/ehci-tegra.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 9e44b1f..d2a7c95 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -285,7 +285,7 @@ static int tegra_ehci_setup(struct usb_hcd *hcd)
>   	/* switch to host mode */
>   	hcd->has_tt = 1;
>   
> -	retval = ehci_setup(ehci);
> +	retval = ehci_setup(hcd);
>   	if (retval)
>   		return retval;
>   

Re: [PATCH] usb: host: tegra: pass correct pointer in ehci_setup()

[Alan Stern]

On Thu, 12 Jul 2012, Laxman Dewangan wrote:

> The ehci_setup() require the pointer of usb_hcd.
> Passing the correct pointer in place of ehci_hcd
> pointer.
> 
> This is side effetct of change:
> commit 1a49e2ac9651df7349867a5cf44e2c83de1046af
> Author: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
> 
>     EHCI: centralize controller initialization
> 
> 
> Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Argh!  You're perfectly right, of course.  I thought I had checked all 
those calls carefully.

Anyway, two other calls need to be fixed as well.  I'll resubmit your 
patch, with the other two fixes included.  Okay?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html