From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19DB6C433E9 for ; Thu, 3 Sep 2020 10:50:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1F8F2086A for ; Thu, 3 Sep 2020 10:50:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="aL+sHYDo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726368AbgICKuP (ORCPT ); Thu, 3 Sep 2020 06:50:15 -0400 Received: from crapouillou.net ([89.234.176.41]:49158 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgICKuM (ORCPT ); Thu, 3 Sep 2020 06:50:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1599130208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YXg3aqgmFb8tKfR4TEoiu32nZCgBWfcl5v4Q44mU658=; b=aL+sHYDogDi8odA19gwRz4rweOeF1jr+yCLbpS1gEROe3fA7E/jfDC5BeFmJAUnF5eryIC IdxX7nQpGG7VkZGyAzxbp9xwe0eFQFIBK58dVNueyRCjIxt/lOYFswheujnU2UtA4nuHiz Erg60GWs/LhPy2ysrTXzXyDxGTvSHyo= Date: Thu, 03 Sep 2020 12:49:52 +0200 From: Paul Cercueil Subject: Re: [PATCH 04/11] mmc: jz4740: Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: Ulf Hansson , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Jaehoon Chung , Jun Nie , Shawn Guo , Kevin Hilman , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , Al Cooper , Adrian Hunter , Michal Simek , Lars Povlsen , Steen Hegelund , Microchip Linux Driver Support , Thierry Reding , Jonathan Hunter , Arnd Bergmann , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-tegra@vger.kernel.org Message-Id: <4RW2GQ.J2DD55HCZMCH2@crapouillou.net> In-Reply-To: <20200902193658.20539-5-krzk@kernel.org> References: <20200902193658.20539-1-krzk@kernel.org> <20200902193658.20539-5-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi Krzysztof, Le mer. 2 sept. 2020 =E0 21:36, Krzysztof Kozlowski a=20 =E9crit : > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. >=20 > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mmc/host/jz4740_mmc.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/mmc/host/jz4740_mmc.c=20 > b/drivers/mmc/host/jz4740_mmc.c > index 81d71010b474..0c5b52b53303 100644 > --- a/drivers/mmc/host/jz4740_mmc.c > +++ b/drivers/mmc/host/jz4740_mmc.c > @@ -991,9 +991,8 @@ static int jz4740_mmc_probe(struct=20 > platform_device* pdev) >=20 > ret =3D mmc_of_parse(mmc); > if (ret) { > - if (ret !=3D -EPROBE_DEFER) > - dev_err(&pdev->dev, > - "could not parse device properties: %d\n", ret); > + dev_err_probe(&pdev->dev, ret, > + "could not parse device properties\n"); I think you can put that on one line. With that said: Reviewed-by: Paul Cercueil Cheers, -Paul > goto err_free_host; > } >=20 > -- > 2.17.1 >=20