From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B25EB64DD for ; Fri, 21 Jul 2023 15:54:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231436AbjGUPx6 (ORCPT ); Fri, 21 Jul 2023 11:53:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230416AbjGUPx4 (ORCPT ); Fri, 21 Jul 2023 11:53:56 -0400 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADA80269F; Fri, 21 Jul 2023 08:53:29 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 23F203200990; Fri, 21 Jul 2023 11:53:05 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 21 Jul 2023 11:53:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1689954784; x=1690041184; bh=9h Pn0vqDK5F4Kupt89UUmDtLQIxvFCQKDf5jwCD/rVE=; b=YMTYZo67fySHWULO6E Ynw7vXR6QCHo3+LO1PXJmKQY3h3qEKR13mS1vI4jsW4yMLYZeLbQGOLXvavWpj/v BT44AHcfYxke0EeNWldO3HHGdVnU+FiBq6YnIpLKpr6B/IFxafXKtmX7mqKrnfy5 bFa2jcPjAltL8ugcQlMCAf1XVcvKMDdQedMdgSlfG1uqwKMUmLt1UA0WSLTKGn/i nRji/7rpZ7SPplPbtPjPGP8tAmFVHRN2c3oFX/f1V8865xnXUa1sBzgBd8+7dlzU vlp29bqlKC5FVTUeowk3uR73JjVmMMXPnckfJCcTujtx2QXFJE07p+oPjFoah1lb 86vQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1689954784; x=1690041184; bh=9hPn0vqDK5F4K upt89UUmDtLQIxvFCQKDf5jwCD/rVE=; b=oneOUSr63ErkU897PPGwDKKr7BkXX U02UoooSEW86a8ho9bKWMp8x6aej4JeA9IbiSCk6KdZgU+z8bsfyF83yONYxJOmQ LDb6nNOuP5COmmiXDi89AQgmBgq8WJqgWKslJmPyuZ9hgq3/IFnRoIuNbObRMrqK 8/CFDzrO+OiiLbO3mYCzWIt7/ZeIWUck7Vc7ePH50vfPo4hkXqTiLQlLyJJXZXj4 hFC09ws2BTQZGDSbIGjLfcD882P6wEQca1KeLh/+GDA8dOzIOt736oqPYoylu/tk e0FEQ1oS76OUIHYBg1FwZBBgCc5MYCEK2XsOi3EWX8W2srf+9JkcvFYgw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrhedvgdeklecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 440A2B6008D; Fri, 21 Jul 2023 11:53:04 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-531-gfdfa13a06d-fm-20230703.001-gfdfa13a0 Mime-Version: 1.0 Message-Id: <4f8ce95e-99ac-40e0-9827-292ef0f67906@app.fastmail.com> In-Reply-To: References: <20230714174438.4054854-1-robh@kernel.org> Date: Fri, 21 Jul 2023 17:52:44 +0200 From: "Arnd Bergmann" To: "Thierry Reding" , "Rob Herring" , "Olof Johansson" Cc: "Sudeep Holla" , "Cristian Marussi" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Florian Fainelli" , "Broadcom internal kernel review list" , "Dinh Nguyen" , "Jon Hunter" , "Michal Simek" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] firmware: Explicitly include correct DT includes Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Fri, Jul 21, 2023, at 17:14, Thierry Reding wrote: > On Fri, Jul 14, 2023 at 11:44:37AM -0600, Rob Herring wrote: >> The DT of_device.h and of_platform.h date back to the separate >> of_platform_bus_type before it as merged into the regular platform bus. >> As part of that merge prepping Arm DT support 13 years ago, they >> "temporarily" include each other. They also include platform_device.h >> and of.h. As a result, there's a pretty much random mix of those include >> files used throughout the tree. In order to detangle these headers and >> replace the implicit includes with struct declarations, users need to >> explicitly include the correct includes. >> >> Signed-off-by: Rob Herring >> --- >> drivers/firmware/arm_scmi/driver.c | 4 ++-- >> drivers/firmware/imx/imx-dsp.c | 1 - >> drivers/firmware/imx/imx-scu-irq.c | 1 + >> drivers/firmware/imx/imx-scu.c | 1 + >> drivers/firmware/mtk-adsp-ipc.c | 1 - >> drivers/firmware/raspberrypi.c | 1 + >> drivers/firmware/scpi_pm_domain.c | 3 ++- >> drivers/firmware/stratix10-rsu.c | 1 - >> drivers/firmware/tegra/bpmp.c | 3 +-- >> drivers/firmware/xilinx/zynqmp.c | 1 + >> 10 files changed, 9 insertions(+), 8 deletions(-) > > Not sure about the other maintainers, but I usually pick up > firmware/tegra patches up through the Tegra tree and then they > ultimately go through ARM SoC. > > Arnd, Olof, does it make sense for you guys to pick this up directly? Sure, I was going to suggest the same thing. Rob, can you send the patch to soc@kernel.org assuming nobody has objections? Feel free to send this together with the bits for drivers/soc, drivers/bus, arch/arm/mach-*/ and anything else that usually gets merged this way. Arnd