Re: [PATCH V3] ARM: dt: tegra: ventana: add regulators

[Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>]

On 08/09/2012 06:03 AM, Laxman Dewangan wrote:
> On Friday 03 August 2012 11:39 PM, Stephen Warren wrote:
>> Ventana uses a TPS6586x regulator. Instantiate this, and hook up a
>> couple of fixed GPIO-controlled regulators too.
...

Sorry, I didn't look below at your other comments. Now responding...

>> +        pmic: tps6586x@34 {
>> +            compatible = "ti,tps6586x";
>> +            reg =<0x34>;
>> +            interrupts =<0 86 0x4>;
> 
> Should we say interrupt-controller also here?

I don't think so; it looks like all the interrupts within this chip are
for things that should be handled completely internally to to driver
itself. Either way, there's certainly nothing attempting to use any
interrupts from this chip right now, so if we did need that property, we
could always add it if/when we added a client that needed it.

>> +
>> +            sys-supply =<&vdd_5v0_reg>;
>> +            vin-sm0-supply =<&sys_reg>;
>> +            vin-sm1-supply =<&sys_reg>;
>> +            vin-sm2-supply =<&sys_reg>;
> 
> This depends on two changes on tps6586x regulator which are not merged yet.

Yes, I'm waiting for those changes to be merged before actually applying
this. However, there's no particular dependency; this patch simply won't
end up enabling the regulators until it's merged with the other patches,
so the .dts and regulator driver patches can go in through separate
trees OK.

>> +    pmc {
> 
> Should say status OK?

The default status is OK. Since the PMC is useful on all boards, it
isn't disabled in tegra30.dtsi; only board-specific things are disabled
in tegra30.dtsi (e.g. which I2C, MMC, I2S, ... ports are used is board
specific. Core SoC functionality isn't.)