From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] mmc: tegra: convert to device tree support only Date: Fri, 17 Aug 2012 13:01:31 -0600 Message-ID: <502E950B.2010205@wwwdotorg.org> References: <1345187071-6619-1-git-send-email-josephl@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1345187071-6619-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chris Ball Cc: Joseph Lo , Olof Johansson , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 08/17/2012 01:04 AM, Joseph Lo wrote: > When compiling a kernel that supports only Tegra30 and not Tegra20, > the SDHCI driver will fail to compile since the of_match_device() failure > fallback code unconditinally references soc_data_tegra20, which is only > compiled in when Tegra20 support is enabled. > > In Kernel 3.7, both Tegra20 and Tegra30 will only support booting using > device tree, Hence, there is never a need to fall back to using > soc_data_tegra20 if of_mach_device() fails. Instead, make this case an > error. This removes the reference to soc_data_tegra20, and hence solves > the compile failure. Tested-by: Stephen Warren (built and tested both Tegra20-only and Tegr30-only kernels with this applied on top of next-20120816).