[PATCH REPOST] usb: phy: tegra remove include of <mach/iomap.h>

[PATCH REPOST] usb: phy: tegra remove include of <mach/iomap.h>

[Stephen Warren]

From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Almost nothing from this file is used, and the file will hopefully be
deleted soon. Copy the tiny portions that are used directly into
tegra_usb_phy.c. I believe that Venu Byravarasu is working on cleaning up
our USB driver, and those cleanups will remove the need for these
constants.

Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Acked-by: Venu Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Felipe, Greg,

This patch is needed in the Tegra branch, since it's a dependency for
cleanup required to support single zImage.

However, I suspect/hope there will be significant improvements to the Tegra
USB driver in 3.8, and this change may merge-conflict with those. It may be
simplest if this patch can /also/ be taken through the USB tree and so act
as a baseline for any Tegra USB work.

As such, may I please request this patch be merged into a separate branch/tag
in the USB tree, which is then merged into both the Tegra and USB trees.

Thanks.
---
 drivers/usb/phy/tegra_usb_phy.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c
index 987116f..9d13c81 100644
--- a/drivers/usb/phy/tegra_usb_phy.c
+++ b/drivers/usb/phy/tegra_usb_phy.c
@@ -29,7 +29,9 @@
 #include <linux/usb/ulpi.h>
 #include <asm/mach-types.h>
 #include <linux/usb/tegra_usb_phy.h>
-#include <mach/iomap.h>
+
+#define TEGRA_USB_BASE		0xC5000000
+#define TEGRA_USB_SIZE		SZ_16K
 
 #define ULPI_VIEWPORT		0x170
 
-- 
1.7.0.4

Re: [PATCH REPOST] usb: phy: tegra remove include of <mach/iomap.h>

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]

hi,

On Mon, Oct 15, 2012 at 12:16:36PM -0600, Stephen Warren wrote:
> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> 
> Almost nothing from this file is used, and the file will hopefully be
> deleted soon. Copy the tiny portions that are used directly into
> tegra_usb_phy.c. I believe that Venu Byravarasu is working on cleaning up
> our USB driver, and those cleanups will remove the need for these
> constants.
> 
> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> Acked-by: Venu Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Felipe, Greg,
> 
> This patch is needed in the Tegra branch, since it's a dependency for
> cleanup required to support single zImage.
> 
> However, I suspect/hope there will be significant improvements to the Tegra
> USB driver in 3.8, and this change may merge-conflict with those. It may be
> simplest if this patch can /also/ be taken through the USB tree and so act
> as a baseline for any Tegra USB work.
> 
> As such, may I please request this patch be merged into a separate branch/tag
> in the USB tree, which is then merged into both the Tegra and USB trees.

I can take this through my transceiver branch, but I would really like
to see v3.8 having a real (platform_)driver ready. The current state of
that code is quite bad IMHO and needs some love.

cheers

ps: will leave this in the mailing list for a few more days before
applying.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH REPOST] usb: phy: tegra remove include of <mach/iomap.h>

[Stephen Warren]

On 10/15/2012 01:22 PM, Felipe Balbi wrote:
> hi,
> 
> On Mon, Oct 15, 2012 at 12:16:36PM -0600, Stephen Warren wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> 
>> Almost nothing from this file is used, and the file will
>> hopefully be deleted soon. Copy the tiny portions that are used
>> directly into tegra_usb_phy.c. I believe that Venu Byravarasu is
>> working on cleaning up our USB driver, and those cleanups will
>> remove the need for these constants.
>> 
>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Acked-by: Venu
>> Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> --- Felipe, Greg,
>> 
>> This patch is needed in the Tegra branch, since it's a dependency
>> for cleanup required to support single zImage.
>> 
>> However, I suspect/hope there will be significant improvements to
>> the Tegra USB driver in 3.8, and this change may merge-conflict
>> with those. It may be simplest if this patch can /also/ be taken
>> through the USB tree and so act as a baseline for any Tegra USB
>> work.
>> 
>> As such, may I please request this patch be merged into a
>> separate branch/tag in the USB tree, which is then merged into
>> both the Tegra and USB trees.
> 
> I can take this through my transceiver branch, but I would really
> like to see v3.8 having a real (platform_)driver ready. The current
> state of that code is quite bad IMHO and needs some love.

Thanks for getting back on this. Please don't *just* take this through
your tree though. What I'm asking for above is a topic branch
containing just this commit, so that commit and branch can be merged
into both your USB branch and my Tegra branch.

Thanks.

Re: [PATCH REPOST] usb: phy: tegra remove include of <mach/iomap.h>

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 2625 bytes --]

Hi,

On Mon, Oct 15, 2012 at 03:22:07PM -0600, Stephen Warren wrote:
> On 10/15/2012 01:22 PM, Felipe Balbi wrote:
> > hi,
> > 
> > On Mon, Oct 15, 2012 at 12:16:36PM -0600, Stephen Warren wrote:
> >> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> >> 
> >> Almost nothing from this file is used, and the file will
> >> hopefully be deleted soon. Copy the tiny portions that are used
> >> directly into tegra_usb_phy.c. I believe that Venu Byravarasu is
> >> working on cleaning up our USB driver, and those cleanups will
> >> remove the need for these constants.
> >> 
> >> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Acked-by: Venu
> >> Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> --- Felipe, Greg,
> >> 
> >> This patch is needed in the Tegra branch, since it's a dependency
> >> for cleanup required to support single zImage.
> >> 
> >> However, I suspect/hope there will be significant improvements to
> >> the Tegra USB driver in 3.8, and this change may merge-conflict
> >> with those. It may be simplest if this patch can /also/ be taken
> >> through the USB tree and so act as a baseline for any Tegra USB
> >> work.
> >> 
> >> As such, may I please request this patch be merged into a
> >> separate branch/tag in the USB tree, which is then merged into
> >> both the Tegra and USB trees.
> > 
> > I can take this through my transceiver branch, but I would really
> > like to see v3.8 having a real (platform_)driver ready. The current
> > state of that code is quite bad IMHO and needs some love.
> 
> Thanks for getting back on this. Please don't *just* take this through
> your tree though. What I'm asking for above is a topic branch
> containing just this commit, so that commit and branch can be merged
> into both your USB branch and my Tegra branch.

done. Already available on my xceiv branch. Here's a pull request:

The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37:

  Linux 3.7-rc1 (2012-10-14 14:41:04 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git tegra-header-cleanup

for you to fetch changes up to 8355b0208a44904741dbd78fea6f203c3556699a:

  usb: phy: tegra remove include of <mach/iomap.h> (2012-10-16 12:48:38 +0300)

----------------------------------------------------------------
Stephen Warren (1):
      usb: phy: tegra remove include of <mach/iomap.h>

 drivers/usb/phy/tegra_usb_phy.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH REPOST] usb: phy: tegra remove include of <mach/iomap.h>

[Stephen Warren]

On 10/16/2012 03:54 AM, Felipe Balbi wrote:
> Hi,
> 
> On Mon, Oct 15, 2012 at 03:22:07PM -0600, Stephen Warren wrote:
>> On 10/15/2012 01:22 PM, Felipe Balbi wrote:
>>> hi,
>>> 
>>> On Mon, Oct 15, 2012 at 12:16:36PM -0600, Stephen Warren
>>> wrote:
>>>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>>> 
>>>> Almost nothing from this file is used, and the file will 
>>>> hopefully be deleted soon. Copy the tiny portions that are
>>>> used directly into tegra_usb_phy.c. I believe that Venu
>>>> Byravarasu is working on cleaning up our USB driver, and
>>>> those cleanups will remove the need for these constants.
>>>> 
>>>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Acked-by:
>>>> Venu Byravarasu <vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> --- Felipe, Greg,
>>>> 
>>>> This patch is needed in the Tegra branch, since it's a
>>>> dependency for cleanup required to support single zImage.
>>>> 
>>>> However, I suspect/hope there will be significant
>>>> improvements to the Tegra USB driver in 3.8, and this change
>>>> may merge-conflict with those. It may be simplest if this
>>>> patch can /also/ be taken through the USB tree and so act as
>>>> a baseline for any Tegra USB work.
>>>> 
>>>> As such, may I please request this patch be merged into a 
>>>> separate branch/tag in the USB tree, which is then merged
>>>> into both the Tegra and USB trees.
>>> 
>>> I can take this through my transceiver branch, but I would
>>> really like to see v3.8 having a real (platform_)driver ready.
>>> The current state of that code is quite bad IMHO and needs some
>>> love.
>> 
>> Thanks for getting back on this. Please don't *just* take this
>> through your tree though. What I'm asking for above is a topic
>> branch containing just this commit, so that commit and branch can
>> be merged into both your USB branch and my Tegra branch.
> 
> done. Already available on my xceiv branch. Here's a pull request:

Thanks very much.

I'll be pulling that branch into Tegra's for-3.8 tree today most likely.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH REPOST] usb: phy: tegra remove include of <mach/iomap.h>

[Stephen Warren]

On 10/15/2012 12:16 PM, Stephen Warren wrote:
> Almost nothing from this file is used, and the file will hopefully be
> deleted soon. Copy the tiny portions that are used directly into
> tegra_usb_phy.c. I believe that Venu Byravarasu is working on cleaning up
> our USB driver, and those cleanups will remove the need for these
> constants.

Per suggestion from Greg, I have applied this to the Tegra tree for 3.8.