* Re: [PATCH] pinctrl: tegra: correct bank for pingroup and drv pingroup
[not found] ` <1350454897-18110-1-git-send-email-praithatha-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
@ 2012-10-17 15:48 ` Stephen Warren
0 siblings, 0 replies; only message in thread
From: Stephen Warren @ 2012-10-17 15:48 UTC (permalink / raw)
To: linus.walleij-QSEj5FYQhm4dnm+yROfE0A
Cc: Pritesh Raithatha, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
swarren-DDmLM1+adcrQT0dZR+AlfA,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On 10/17/2012 12:21 AM, Pritesh Raithatha wrote:
> Signed-off-by: Pritesh Raithatha <praithatha-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
(dropping stable from CC)
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Linus, if you could add Cc: stable when you commit it, that'd be useful
too. Thanks.
I have no idea how I screwed this up so badly, or how it worked when
programming completely bogus registers!
Adding a patch description would be useful especially for stable. A
useful patch description might be:
The bank numbers in the pinctrl driver must match the bank numbers in
the device tree. Swap the bank numbers in the driver to ensure this.
While we're at it, rename the #defines used for the bank base addresses
so it's more obvious which is which, and add comments indicating which
correspond to which device tree bank.
^ permalink raw reply [flat|nested] only message in thread