* [PATCH] ASoC: tegra: update spdif tx_atn_lvl on hw_params()
@ 2012-10-30 14:23 Dmitry Osipenko
2012-10-30 18:23 ` Stephen Warren
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Osipenko @ 2012-10-30 14:23 UTC (permalink / raw)
To: swarren; +Cc: digetx, tiwai, linux-tegra, linux-kernel
This prevents playing sound with wrong speed.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
I'm using deep sleep on my tablet and faced with this bug when played sound via
hdmi after suspend. I know that there is no deep sleep support in upstream kernel,
but will be nice to see that bug fixed.
sound/soc/tegra/tegra20_spdif.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/soc/tegra/tegra20_spdif.c b/sound/soc/tegra/tegra20_spdif.c
index 3ebc867..24b46f1 100644
--- a/sound/soc/tegra/tegra20_spdif.c
+++ b/sound/soc/tegra/tegra20_spdif.c
@@ -114,6 +114,10 @@ static int tegra20_spdif_hw_params(struct snd_pcm_substream *substream,
return ret;
}
+ regmap_update_bits(spdif->regmap, TEGRA20_SPDIF_DATA_FIFO_CSR,
+ TEGRA20_SPDIF_DATA_FIFO_CSR_TX_ATN_LVL_MASK,
+ TEGRA20_SPDIF_DATA_FIFO_CSR_TX_ATN_LVL_TU4_WORD_FULL);
+
return 0;
}
--
1.7.12
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: tegra: update spdif tx_atn_lvl on hw_params()
2012-10-30 14:23 [PATCH] ASoC: tegra: update spdif tx_atn_lvl on hw_params() Dmitry Osipenko
@ 2012-10-30 18:23 ` Stephen Warren
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2012-10-30 18:23 UTC (permalink / raw)
To: Dmitry Osipenko; +Cc: swarren, tiwai, linux-tegra, linux-kernel
On 10/30/2012 08:23 AM, Dmitry Osipenko wrote:
> This prevents playing sound with wrong speed.
Reviewed-by: Stephen Warren <swarren@nvidia.com>
I guess this is fine, although as you say it makes little practical
difference in the mainline kernel; I'm sure there is much other work to
be done in order to support suspend/resume.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-30 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-30 14:23 [PATCH] ASoC: tegra: update spdif tx_atn_lvl on hw_params() Dmitry Osipenko
2012-10-30 18:23 ` Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).