linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver
Date: Tue, 30 Oct 2012 14:29:46 -0600	[thread overview]
Message-ID: <509038BA.30600@wwwdotorg.org> (raw)
In-Reply-To: <1351580726-17350-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 10/30/2012 01:05 AM, Laxman Dewangan wrote:
> This series modify the dts file to add the slink addresses,
> make AUXDATA in board dt files, enable slink4 for tegra30-cardhu and 
> enable slink controller defconfig.

This series only instantiates the SPI controller, and not any SPI
devices. I tried to solve this:

> diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> index 700f0a3..3689853 100644
> --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
> +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
> @@ -278,6 +278,11 @@
>         spi@7000da00 {
>                 status = "okay";
>                 spi-max-frequency = <25000000>;
> +               flash@0 {
> +                       reg = <0>;
> +                       compatible = "atmel,at25df321a";
> +                       spi-max-frequency = <25000000>;
> +               };
>         };
>  
>         ahub {

However, this didn't work. Has the driver been tested? I'm seeing the
exact same problems I saw with the old driver, namely that the SPI flash
chip can't be identified; I think the ID bytes are read back as 0, and
hence drivers/mtd/devices/m25p80.c falls back to identifying the device
as mr25h256. Attempting to hexdump -C /dev/mtd0 gives me 32K of zeros,
whereas the device is 4M and full of non-zero data according to U-Boot.

Do you know what the problem is here? Can you please update the patch
series so that the SPI flash is instantiated and works correctly?

  parent reply	other threads:[~2012-10-30 20:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30  7:05 [PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver Laxman Dewangan
2012-10-30  7:05 ` [PATCH V3 1/4] ARM: tegra: dts: add slink controller dt entry Laxman Dewangan
     [not found] ` <1351580726-17350-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-10-30  7:05   ` [PATCH V3 2/4] ARM: tegra: Add OF_DEV_AUXDATA for SLINK driver in board dt Laxman Dewangan
2012-10-30  7:05   ` [PATCH V3 3/4] ARM: tegra: dts: cardhu: enable SLINK4 Laxman Dewangan
2012-10-30 20:29   ` Stephen Warren [this message]
     [not found]     ` <509038BA.30600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-31  8:51       ` [PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver Laxman Dewangan
2012-10-31 16:06         ` Stephen Warren
2012-10-31 17:33           ` Laxman Dewangan
2012-10-30  7:05 ` [PATCH V3 4/4] ARM: tegra: config: enable spi driver for Tegra SLINK controller Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509038BA.30600@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).