linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: balbi-l0cyMroinI0@public.gmane.org
Cc: Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH REPOST] usb: host: tegra remove include of <mach/iomap.h>
Date: Wed, 31 Oct 2012 10:17:13 -0600	[thread overview]
Message-ID: <50914F09.6000404@wwwdotorg.org> (raw)
In-Reply-To: <20121031125131.GJ10998-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>

On 10/31/2012 06:51 AM, Felipe Balbi wrote:
> Hi,
> 
> On Mon, Oct 29, 2012 at 11:01:08AM -0600, Stephen Warren wrote:
>> On 10/24/2012 01:29 PM, Stephen Warren wrote:
>>> Almost nothing from this file is used, and the file will
>>> hopefully be deleted soon. Copy the tiny portions that are used
>>> directly into ehci-tegra.c. I believe that Venu Byravarasu is
>>> working on cleaning up our USB driver, and those cleanups will
>>> remove the need for these constants.
>> 
>> Per suggestion from Greg, I have applied this to the Tegra tree
>> for 3.8.
> 
> so I need not take this patch in my tree, right ?
> 
> just making sure.

I'm fairly sure you'll want to have the patch in your tree too; Greg's
suggestion was simply to merge it everywhere it was needed.

To summarize:

* I've applied the patch to the Tegra tree since it's a dependency for
some cleanup.

* I think it's needed in whichever USB tree(s) will take the
forthcoming Tegra PHY driver rework. Apparently that's your PHY tree.
This is however simply to avoid any merge conflicts. If the PHY driver
rework ends up not adding any extra includes of <mach/iomap.h>
(unlikely if new files are added) then perhaps it isn't needed. Also,
if the PHY driver rework ends up not re-arranging the includes a lot,
then perhaps it will merge OK without you needing the patch. If you
want, perhaps the best course of action is to hold off applying the
patch until the PHY driver rework patches appear, and it's obvious
whether there will be a hard-to-resolve conflict, and only apply the
patch if strictly needed to avoid sticky merge conflicts.

* Greg has taken both patches into his USB tree already. Does
development process allow you to simply merge that?

  parent reply	other threads:[~2012-10-31 16:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 19:29 [PATCH REPOST] usb: host: tegra remove include of <mach/iomap.h> Stephen Warren
     [not found] ` <1351106941-869-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-24 19:43   ` Alan Stern
2012-10-29 17:01   ` Stephen Warren
     [not found]     ` <508EB654.8030502-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-31 12:51       ` Felipe Balbi
     [not found]         ` <20121031125131.GJ10998-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-31 16:17           ` Stephen Warren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-10-15 18:15 Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50914F09.6000404@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=balbi-l0cyMroinI0@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).