From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] drm: Add NVIDIA Tegra30 support Date: Fri, 16 Nov 2012 09:43:41 -0700 Message-ID: <50A66D3D.4040708@wwwdotorg.org> References: <1353041889-3114-1-git-send-email-markz@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1353041889-3114-1-git-send-email-markz-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Zhang Cc: airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 11/15/2012 09:58 PM, Mark Zhang wrote: > This patch is based on Thierry's drm patch for Tegra20: > - [PATCH v2 0/6] Device tree updates for host1x support > - [PATCH v3 0/2] NVIDIA Tegra DRM driver > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index 216cd0f..6e9f1b4 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -819,6 +819,7 @@ static int tegra_dc_remove(struct platform_device *pdev) > > static struct of_device_id tegra_dc_of_match[] = { > { .compatible = "nvidia,tegra20-dc", }, > + { .compatible = "nvidia,tegra30-dc", }, The Tegra30 entries should come first in the table due to the order the kernel (currently) matches compatible properties against theses tables. The same comment applies for all 3 tables. With the patch manually applied (due to the whitespace issues I mentioned earlier), and this ordering issue fixed, Tested-by: Stephen Warren (On Cardhu, with no HDMI plugged in; see my next email for details).