From: "Terje Bergström" <tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Sivaram Nair <sivaramn-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Arto Merilainen
<amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/6] video: tegra: Add nvhost driver
Date: Mon, 26 Nov 2012 11:23:10 +0200 [thread overview]
Message-ID: <50B334FE.6040801@nvidia.com> (raw)
In-Reply-To: <20121123123954.GB10090@sivaramn-lnx>
On 23.11.2012 14:39, Sivaram Nair wrote:
> Should this be static (considering that the below function exist)?
(...)
All your comments were valid, and I fixed the code. Thanks.
I ended up ripping away the alloc memmgr call and mem_mgr pointers in
functions. We use that call in downstream for allocating an instance of
nvmap, but in dmabuf case there's no client to be allocated, and thus
the calls were empty.
Terje
next prev parent reply other threads:[~2012-11-26 9:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 12:16 [PATCH 0/6] Support for Tegra 2D hardware Terje Bergstrom
[not found] ` <1353586614-7308-1-git-send-email-tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-22 12:16 ` [PATCH 1/6] video: tegra: Add nvhost driver Terje Bergstrom
[not found] ` <1353586614-7308-2-git-send-email-tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-23 12:39 ` Sivaram Nair
2012-11-26 9:23 ` Terje Bergström [this message]
2012-11-26 22:59 ` Stephen Warren
2012-11-23 15:29 ` Thierry Reding
[not found] ` <20121123152926.GA20046-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-11-23 15:43 ` Terje Bergström
2012-11-22 12:16 ` [PATCH 2/6] ARM: tegra: Add auxiliary data for nvhost Terje Bergstrom
2012-11-22 12:16 ` [PATCH 3/6] gpu: drm: tegra: Remove redundant host1x Terje Bergstrom
[not found] ` <1353586614-7308-4-git-send-email-tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-23 8:24 ` Sivaram Nair
2012-11-22 12:16 ` [PATCH 4/6] gpu: drm: tegra: Free platform data on remove Terje Bergstrom
2012-11-22 12:16 ` [PATCH 5/6] gpu: drm: tegra: Prime support Terje Bergstrom
2012-11-22 12:16 ` [PATCH 6/6] drm: tegra: Add gr2d device Terje Bergstrom
-- strict thread matches above, loose matches on Subject: below --
2012-11-22 9:47 [PATCH 0/6] Support for Tegra 2D hardware Terje Bergstrom
[not found] ` <1353577684-7896-1-git-send-email-tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-22 9:47 ` [PATCH 1/6] video: tegra: Add nvhost driver Terje Bergstrom
[not found] ` <1353577684-7896-2-git-send-email-tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-23 23:38 ` Thierry Reding
[not found] ` <20121123233855.GD21555-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-11-24 7:00 ` Terje Bergström
[not found] ` <50B07084.40707-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-24 19:04 ` Thierry Reding
[not found] ` <20121124190416.GC26154-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-11-24 20:02 ` Terje Bergström
2012-11-26 8:21 ` Terje Bergström
[not found] ` <50B32690.7020102-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-26 9:25 ` Thierry Reding
[not found] ` <20121126092524.GB8602-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org>
2012-11-26 9:33 ` Terje Bergström
2012-11-26 13:42 ` Terje Bergström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B334FE.6040801@nvidia.com \
--to=tbergstrom-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sivaramn-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).