linux-tegra.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/5] ARM: tegra20: clocks: add CPU low-power function into tegra_cpu_car_ops
Date: Mon, 03 Dec 2012 11:20:26 -0700	[thread overview]
Message-ID: <50BCED6A.7000702@wwwdotorg.org> (raw)
In-Reply-To: <1354503607-13707-3-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 12/02/2012 08:00 PM, Joseph Lo wrote:
> Add suspend, resume and rail_off_ready API into tegra_cpu_car_ops. These
> functions were used for CPU powered-down state maintenance.

> diff --git a/arch/arm/mach-tegra/tegra20_clocks.c b/arch/arm/mach-tegra/tegra20_clocks.c

> +static bool tegra20_cpu_rail_off_ready(void)

> +	if ((cpu_rst_status & 0x2) != 0x2)
> +		return false;
> +
> +	return true;
> +}

Perhaps simplify that to:

return cpu_rst_status & 2;

or perhaps if that generates an int->bool performance warning:

return !!(cpu_rst_status & 2);

or:

return (cpu_rst_status >> 1) & 1;

  parent reply	other threads:[~2012-12-03 18:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03  3:00 [PATCH 0/5] ARM: tegra20: cpuidle: add power-down state Joseph Lo
     [not found] ` <1354503607-13707-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-03  3:00   ` [PATCH 1/5] ARM: tegra20: cpuidle: add powered-down state for secondary CPU Joseph Lo
     [not found]     ` <1354503607-13707-2-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-03 18:18       ` Stephen Warren
     [not found]         ` <50BCED09.4040700-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-04  6:47           ` Joseph Lo
2012-12-03 18:31       ` Stephen Warren
     [not found]         ` <50BCF01E.4070504-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-04  7:05           ` Joseph Lo
     [not found]             ` <1354604712.30563.31.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2012-12-05 18:36               ` Stephen Warren
2012-12-03  3:00   ` [PATCH 2/5] ARM: tegra20: clocks: add CPU low-power function into tegra_cpu_car_ops Joseph Lo
     [not found]     ` <1354503607-13707-3-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-03 18:20       ` Stephen Warren [this message]
     [not found]         ` <50BCED6A.7000702-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-04  4:28           ` Joseph Lo
2012-12-04  5:12       ` Prashant Gaikwad
     [not found]         ` <50BD8646.6070608-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-04  5:25           ` Joseph Lo
     [not found]             ` <1354598707.30563.10.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2012-12-05 18:34               ` Stephen Warren
2012-12-03  3:00   ` [PATCH 3/5] ARM: tegra20: flowctrl: add support for cpu_suspend_enter/exit Joseph Lo
2012-12-03  3:00   ` [PATCH 4/5] ARM: tegra20: cpuidle: add powered-down state for CPU0 Joseph Lo
     [not found]     ` <1354503607-13707-5-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-03 18:40       ` Stephen Warren
     [not found]         ` <50BCF226.1080501-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-04  7:25           ` Joseph Lo
2012-12-03  3:00   ` [PATCH 5/5] ARM: tegra20: cpuidle: apply coupled cpuidle for powered-down mode Joseph Lo
     [not found]     ` <1354503607-13707-6-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-12-03 18:52       ` Stephen Warren
     [not found]         ` <50BCF4F8.60606-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-04 10:20           ` Joseph Lo
2012-12-04 12:41           ` Peter De Schrijver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50BCED6A.7000702@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).