From: "Terje Bergström" <tbergstrom-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
Cc: "thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org"
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>,
"dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org"
<dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
Arto Merilainen
<amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCHv3 4/7] gpu: host1x: Add debug support
Date: Mon, 17 Dec 2012 16:01:09 +0200 [thread overview]
Message-ID: <50CF25A5.2050803@nvidia.com> (raw)
In-Reply-To: <1355412191.12036.2.camel@joe-AO722>
On 13.12.2012 17:23, Joe Perches wrote:
> On Thu, 2012-12-13 at 16:04 +0200, Terje Bergstrom wrote:
>> Add support for host1x debugging. Adds debugfs entries, and dumps
>> channel state to UART in case of stuck job.
>
> trivial note:
>
> []
>
>> diff --git a/drivers/gpu/host1x/debug.h b/drivers/gpu/host1x/debug.h
> []
>> +void host1x_debug_output(struct output *o, const char *fmt, ...);
>
> This should be marked __printf(2, 3)
> so the compiler verifies format and argument types.
Thanks, I didn't know of this "trick". I'll apply it in the next version.
Considering the amount of feedback I've received from the patches, they
must be top notch quality!
Terje
next prev parent reply other threads:[~2012-12-17 14:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 14:04 [PATCHv3 0/7] Support for Tegra 2D hardware Terje Bergstrom
2012-12-13 14:04 ` [PATCHv3 1/7] gpu: host1x: Add host1x driver Terje Bergstrom
2012-12-13 14:04 ` [PATCHv3 2/7] gpu: host1x: Add syncpoint wait and interrupts Terje Bergstrom
2012-12-13 14:04 ` [PATCHv3 3/7] gpu: host1x: Add channel support Terje Bergstrom
2012-12-13 14:04 ` [PATCHv3 4/7] gpu: host1x: Add debug support Terje Bergstrom
2012-12-13 15:23 ` Joe Perches
2012-12-17 14:01 ` Terje Bergström [this message]
2012-12-17 17:04 ` Joe Perches
2012-12-13 14:04 ` [PATCHv3 5/7] drm: tegra: Remove redundant host1x Terje Bergstrom
2012-12-13 14:04 ` [PATCHv3 6/7] ARM: tegra: Add board data and 2D clocks Terje Bergstrom
2012-12-13 14:04 ` [PATCHv3 7/7] drm: tegra: Add gr2d device Terje Bergstrom
2012-12-13 15:03 ` [PATCHv3 0/7] Support for Tegra 2D hardware Lucas Stach
2012-12-13 15:33 ` Terje Bergström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CF25A5.2050803@nvidia.com \
--to=tbergstrom-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=amerilainen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=dev-8ppwABl0HbeELgA04lAiVw@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).