From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prashant Gaikwad Subject: Re: [PATCH] ARM: tegra: cpufreq: move clk_get/put out of function tegra_cpu_init/exit Date: Sun, 23 Dec 2012 16:05:26 +0530 Message-ID: <50D6DE6E.4060106@nvidia.com> References: <1356084595-17800-1-git-send-email-linuxzsc@gmail.com> <50D4D44F.2080203@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50D4D44F.2080203-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Richard Zhao , Peter De Schrijver , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Saturday 22 December 2012 02:57 AM, Stephen Warren wrote: > On 12/21/2012 03:09 AM, Richard Zhao wrote: >> tegra_cpu_init/exit will be called every time one cpu core is online or >> offline. And all cpu cores share same clocks, redundant clk_get/put >> wast time, so I move them out. > I think this is reasonable. > > Prashant, Peter, any comments? > > Is any other work in tegra_cpu_init() redundant? Is tegra_cpu_init() > supposed to be called due to hotplug, or is that a bug in the cpufreq core? Looks good. Also, instead of array we can use single variable for target_cpu_speed.