From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prashant Gaikwad Subject: Re: [PATCH v3 0/9] Migrate Tegra to common clock framework Date: Wed, 9 Jan 2013 16:29:53 +0530 Message-ID: <50ED4DA9.3090406@nvidia.com> References: <1357292453-28418-1-git-send-email-pgaikwad@nvidia.com> <50E70FE5.9010001@wwwdotorg.org> <50EB6403.5090300@wwwdotorg.org> <50EC1CD3.3070308@nvidia.com> <50EC6A37.4000206@wwwdotorg.org> <50EC8947.4080704@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50EC8947.4080704-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: "mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , Stephen Warren , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Wednesday 09 January 2013 02:31 AM, Stephen Warren wrote: > On 01/08/2013 11:49 AM, Stephen Warren wrote: >> On 01/08/2013 06:19 AM, Prashant Gaikwad wrote: >>> On Tuesday 08 January 2013 05:40 AM, Stephen Warren wrote: >>>> On 01/04/2013 10:22 AM, Stephen Warren wrote: >>>>> On 01/04/2013 02:40 AM, Prashant Gaikwad wrote: >>>>>> This patchset does following: >>>>>> 1. Decompose single tegra clock structure into multiple clocks. >>>>>> 2. Try to use standard clock types supported by common clock framework. >>>>>> 3. Use dynamic initialization. >>>>>> 4. Move all clock code to drivers/clk/tegra from mach-tegra. >>>>>> 5. Add device tree support for Tegra20 and Tegra30 clocks. >>>>>> 6. Remove all legacy clock code from mach-tegra. >>>>> I think there are bugs here. I applied all your clock patches on top of >>>>> Tegra's for-next (see list below), and found that the following don't >>>>> work on Springbank: >>>>> >>>>> * HDMI display >>>>> * Audio playback >>>>> * WiFi >>>> (BTW, I stopped Cc'ing linux-kernel@, but added linux-tegra@ instead...) >>>> >>>> Prashant, some updated testing results based off the "dev/ccf" branch >>>> you sent me on our internal git server: >> ... >>> I have updated the internal branch with all the above mentioned fixes. > ... >> The remaining item is the display issue on Tegra30, which I'll go look >> at now. > The USB3 clock, which isn't used by any drivers on Tegra30, and hence > was disabled at boot, was set up incorrectly and ended up mapping to the > disp1 clock, and hence turned off the display. The following fixes it: Stephen, thanks for the fix!! I have included this and PLLE fix; updated internal branch. Please let me know if it is good to merge now, I will send the patches. >> diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c >> index f2f526e..0bac07c 100644 >> --- a/drivers/clk/tegra/clk-tegra30.c >> +++ b/drivers/clk/tegra/clk-tegra30.c >> @@ -1541,7 +1541,7 @@ static void __init tegra30_periph_clk_init(void) >> >> /* usb3 */ >> clk = tegra_clk_periph_gate("usb3", "clk_m", 0, clk_base, 0, 59, >> - &periph_l_regs, periph_clk_enb_refcnt); >> + &periph_h_regs, periph_clk_enb_refcnt); >> clk_register_clkdev(clk, NULL, "tegra-ehci.2"); >> clks[usb3] = clk; > I wonder if there are any other similar issues? Reviewed, there were none.