From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 1/9] ARM: dt: add header to define GPIO flags Date: Thu, 14 Feb 2013 16:29:53 -0700 Message-ID: <511D7371.6040603@wwwdotorg.org> References: <1360791198-29462-1-git-send-email-swarren@wwwdotorg.org><1360791198-29462-2-git-send-email-swarren@wwwdotorg.org> <20130214.224816.1898594449880044716.hdoyu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130214.224816.1898594449880044716.hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hiroshi Doyu Cc: "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , "olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org" , "arnd-r2nGTMty4D4@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Stephen Warren List-Id: linux-tegra@vger.kernel.org On 02/14/2013 01:48 PM, Hiroshi Doyu wrote: > Stephen Warren wrote @ Wed, 13 Feb 2013 22:33:10 +0100: >> Many GPIO device tree bindings use the same flags. Create a header to >> define those. ... [discussion about adding include guards] > To avoid multple inclusion problems, do we want the above > ifdef/define/endif for other DT header files as well? Yes, we should probably add include guards to all the files. I'll update my patch series.