From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Ni Subject: Re: [RFC PATCH 4/9] hwmon: (lm90) use macros for the indexes of temp8 and temp11 Date: Wed, 20 Feb 2013 18:29:15 +0800 Message-ID: <5124A57B.3050403@nvidia.com> References: <1361187031-3679-1-git-send-email-wni@nvidia.com> <1361187031-3679-5-git-send-email-wni@nvidia.com> <51240497.8010909@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51240497.8010909-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: "durgadoss.r-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , "rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" , Matthew Longnecker , "khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TZX6JHB/w77yyCwEArCW2h5@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 02/20/2013 07:02 AM, Stephen Warren wrote: > On 02/18/2013 04:30 AM, Wei Ni wrote: >> Using macros for the indexes and nrs of temp8 and temp11. >> This make the code much clearer. > > Sorry to nit-pick, but those aren't macros, but rather they're enums. Yes, you are right, it's better to write "enums". I will change it. Wei. > > The patch looks good though. >