From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/2] mmc: tegra: use mmc_of_parse to get the support of standard MMC DT bindings Date: Wed, 20 Feb 2013 21:20:05 -0700 Message-ID: <5125A075.5000000@wwwdotorg.org> References: <1361343902-15223-1-git-send-email-josephl@nvidia.com> <1361343902-15223-3-git-send-email-josephl@nvidia.com> <512502D7.4090605@wwwdotorg.org> <1361413425.5678.8.camel@jlo-ubuntu-64.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1361413425.5678.8.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joseph Lo Cc: Chris Ball , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On 02/20/2013 07:23 PM, Joseph Lo wrote: > On Thu, 2013-02-21 at 01:07 +0800, Stephen Warren wrote: >> On 02/20/2013 12:05 AM, Joseph Lo wrote: >>> Updating the sdhci-tegra driver to use mmc_of_parse to support standard >>> MMC DT bindings. Then we can remove the redundant code that already support >>> @@ -220,15 +203,12 @@ static void sdhci_tegra_parse_dt(struct device *dev, >>> struct sdhci_tegra *tegra_host) >>> { >> ... >>> + struct sdhci_host *host; >> ... >>> + host = platform_get_drvdata(to_platform_device(dev)); >>> + mmc_of_parse(host->mmc); >>> } >> >> It might be simpler to change the function prototype to simply pass in >> the host object too. > > It's a interface problem that I can't fix now. If sdhci core is going to > integrate mmc_of_parse into sdhci_get_of_property and mmc_gpio_get_ro > into somethere sdhci_do_get_ro, then we can refine later. I meant to change the prototype of sdhci_tegra_parse_dt(). It would be simple to change that function in this patch.