public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 03/10] ARM: tegra: get power management configurations for PMC from DT
Date: Tue, 05 Mar 2013 11:33:57 -0700	[thread overview]
Message-ID: <51363A95.8090000@wwwdotorg.org> (raw)
In-Reply-To: <1362397207-5597-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 03/04/2013 04:40 AM, Joseph Lo wrote:
> If the system supports deep sleep mode (i.e. suspend), it should have
> the power management configuration for PMC in the DT under the sub-node
> of PMC. Different system may have different configurations, it should
> be parsed from DT.

> diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c

> @@ -143,6 +161,10 @@ static const struct of_device_id matches[] __initconst = {
>  static void tegra_pmc_parse_dt(void)
>  {
>  	struct device_node *np;
> +	u32 prop;
> +	enum tegra_suspend_mode suspend_mode;
> +	u32 core_good_time[2] = {0, 0};
> +	u32 lp0_vec[2] = {0, 0};
>  
>  	np = of_find_matching_node(NULL, matches);
>  	BUG_ON(!np);

This files doesn't look like that; the BUG_ON() isn't present upstream
yet. So, this series depends on some other patches not yet applied. You
need to explicitly document your patch dependencies somewhere. Hopefully
I can work it out...

The DT binding documentation patch (5/10) should be squashed into this
patch; both document and implement the bindings in the same patch.

  parent reply	other threads:[~2013-03-05 18:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 11:40 [PATCH 03/10] ARM: tegra: get power management configurations for PMC from DT Joseph Lo
     [not found] ` <1362397207-5597-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-05 18:33   ` Stephen Warren [this message]
     [not found]     ` <51363A95.8090000-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-07 10:46       ` Joseph Lo
     [not found]         ` <1362653181.1890.3.camel-yx3yKKdKkHfc7b1ADBJPm0n48jw8i0AO@public.gmane.org>
2013-03-07 20:43           ` Stephen Warren
2013-03-05 18:41   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51363A95.8090000@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox