From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V2 3/3] get_maintainer: prevent keywords from matching filenames Date: Wed, 06 Mar 2013 23:47:28 -0700 Message-ID: <51383800.7000608@wwwdotorg.org> References: <1362616141-13947-1-git-send-email-swarren@wwwdotorg.org> <1362616141-13947-3-git-send-email-swarren@wwwdotorg.org> <1362616252.2093.37.camel@joe-AO722> <5137E09E.1060006@wwwdotorg.org> <1362616810.2093.40.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1362616810.2093.40.camel@joe-AO722> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Joe Perches Cc: Andrew Morton , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marcin Slusarz , Lucas Stach , Borislav Petkov , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Maarten Lankhorst , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren List-Id: linux-tegra@vger.kernel.org On 03/06/2013 05:40 PM, Joe Perches wrote: > On Wed, 2013-03-06 at 17:34 -0700, Stephen Warren wrote: >> On 03/06/2013 05:30 PM, Joe Perches wrote: >>> On Wed, 2013-03-06 at 17:29 -0700, Stephen Warren wrote: >>>> From: Stephen Warren >>>> >>>> This reverts most of eb90d08 "get_maintainer: allow keywords to match >>>> filenames"; all except the parts that are required to implement the new >>>> N: entry type. >>> >>> Just combine patches 1 and 3 into a single patch. >> >> That would break bisectability; using MAINTAINERS after applying a >> squashed 1+3 but without patch 2 applied would not operate as desired. > > > > Which is why I showed the whole thing in a single patch. > No worries if it's simply to increase the patch count... I'm not sure what showed refers to? I guess if I squashed /everything/ into a single commit (i.e. the change to the Tegra section in MAINTAINERS too) then there wouldn't be any bisect issues. I really don't care about patch count. The reason for >1 patch is that there's often push-back if doing logically separate things (adding N: feature, modifying a MAINTAINERS entry to use it, removing part of K: feature) in a single patch...