From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power management Date: Mon, 11 Mar 2013 14:26:40 +0530 Message-ID: <513D9C48.8090505@nvidia.com> References: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com> <1362991468-30226-3-git-send-email-ldewangan@nvidia.com> <20130311085132.GA7900@avionic-0098.mockup.avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130311085132.GA7900-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: "akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org" , "a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org" , "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org" , "rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Monday 11 March 2013 02:21 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Mar 11, 2013 at 02:14:25PM +0530, Laxman Dewangan wrote: > [...] >> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c > [...] >> @@ -431,6 +430,8 @@ static int tegra_rtc_resume(struct platform_device *pdev) >> } >> #endif >> >> +SIMPLE_DEV_PM_OPS(tegra_rtc_pm_ops, tegra_rtc_suspend, tegra_rtc_resume); > I should've been more explicit. Since you had this marked as static in > the previous patch, this needs to be static SIMPLE_DEV_PM_OPS. Yaah, I should keep the static. I think I will need to respin this patch only in place of whole series. Andrew, Let me know if this is fine. Thanks, Laxman