From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V2 2/5] ARM: DT: tegra114: Add i2c controller DT entry Date: Mon, 11 Mar 2013 11:35:37 -0600 Message-ID: <513E15E9.8090904@wwwdotorg.org> References: <1362852678-13421-1-git-send-email-ldewangan@nvidia.com> <1362852678-13421-3-git-send-email-ldewangan@nvidia.com> <20130310223936.GF4743@avionic-0098.mockup.avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130310223936.GF4743-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Laxman Dewangan , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/10/2013 04:39 PM, Thierry Reding wrote: > On Sat, Mar 09, 2013 at 11:41:15PM +0530, Laxman Dewangan wrote: >> NVIDIA's Tegra114 has 5 i2c controllers. These controllers have >> additional feature/configurations to make it functional over >> Tegra30's i2c controller driver. >> >> Add DT entry for i2c controllers and make it compatible with >> "nvidia,tegra114-i2c". > > Both the subject and description should probably use I2C instead of > i2c. Also I don't understand what "make it functional over" means. > Perhaps, since the entries aren't marked compatible with > nvidia,tegra30-i2c you meant to say that they are incompatible with > Tegra30? The second sentence Laxman wrote above should probably say: These controllers have a modified clocking structure that make them incompatible with previous hardware.