public inbox for linux-tegra@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding
	<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: Laxman Dewangan
	<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH V2 3/5] ARM: DT: tegra114:add aliases and DMA requestor for serial controller
Date: Mon, 11 Mar 2013 11:42:47 -0600	[thread overview]
Message-ID: <513E1797.4010808@wwwdotorg.org> (raw)
In-Reply-To: <20130310224219.GG4743-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>

On 03/10/2013 04:42 PM, Thierry Reding wrote:
> On Sat, Mar 09, 2013 at 11:41:16PM +0530, Laxman Dewangan wrote: 
> [...]
>> diff --git a/arch/arm/boot/dts/tegra114.dtsi 
>> b/arch/arm/boot/dts/tegra114.dtsi
> [...]
>> @@ -99,38 +106,50 @@ 0x70003000 0x40c>;	/* Mux registers */ };
>> 
>> -	serial@70006000 { +	/* +	 * There are two serial driver i.e. 
>> 8250 based simple serial +	 * driver and APB DMA based serial 
>> driver for higher baudrate +	 * and performace. To enable the 
>> 8250 based driver, the compatible +	 * is
>> "nvidia,tegra114-uart", "nvidia,tegra20-uart" and to enable +	 *
>> the APB DMA based serial driver, the comptible is +	 *
>> "nvidia,tegra114-hsuart", "nvidia,tegra30-hsuart". +	 */ +	uarta:
>> serial@70006000 {
> 
> I'm not sure if this is a good place for this comment. Perhaps it 
> should go into the binding documentation?

It is at least consistent with previous tegra20/30.dtsi. The two
compatible values are separate bindings, so a clue here re: which one
to go look at isn't a bad idea, although I agree that having each
binding document mention the other one would also be good.

  parent reply	other threads:[~2013-03-11 17:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09 18:11 [PATCH V2 0/5] ARM: DT: tegra114: Add DT entry for different controller Laxman Dewangan
2013-03-09 18:11 ` [PATCH V2 1/5] ARM: DT: tegra114: add APB DMA controller DT entry Laxman Dewangan
2013-03-10 22:37   ` Thierry Reding
2013-03-09 18:11 ` [PATCH V2 2/5] ARM: DT: tegra114: Add i2c " Laxman Dewangan
     [not found]   ` <1362852678-13421-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-10 22:39     ` Thierry Reding
     [not found]       ` <20130310223936.GF4743-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2013-03-11 17:35         ` Stephen Warren
2013-03-11 17:41   ` Stephen Warren
2013-03-09 18:11 ` [PATCH V2 5/5] ARM: DT: tegra114: Add spi " Laxman Dewangan
     [not found]   ` <1362852678-13421-6-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-10 22:51     ` Thierry Reding
     [not found] ` <1362852678-13421-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-09 18:11   ` [PATCH V2 3/5] ARM: DT: tegra114:add aliases and DMA requestor for serial controller Laxman Dewangan
     [not found]     ` <1362852678-13421-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-10 22:42       ` Thierry Reding
     [not found]         ` <20130310224219.GG4743-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2013-03-11 17:42           ` Stephen Warren [this message]
2013-03-11 17:38     ` Stephen Warren
2013-03-09 18:11   ` [PATCH V2 4/5] ARM: DT: tegra114: add KBC controller DT entry Laxman Dewangan
2013-03-11 17:43     ` Stephen Warren
     [not found]       ` <513E17C1.1070305-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-11 17:59         ` Laxman Dewangan
2013-03-11 18:47           ` Stephen Warren
2013-03-11 22:15   ` [PATCH V2 0/5] ARM: DT: tegra114: Add DT entry for different controller Stephen Warren
     [not found]     ` <513E5771.9000408-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-12 10:11       ` Laxman Dewangan
     [not found]         ` <513EFF36.50107-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-12 18:31           ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513E1797.4010808@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox