From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] ARM: dt: tegra114: add PWM nodes
Date: Mon, 11 Mar 2013 17:30:11 -0600 [thread overview]
Message-ID: <513E6903.6060506@wwwdotorg.org> (raw)
In-Reply-To: <1363041036-26358-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/11/2013 04:30 PM, Andrew Chew wrote:
> This patch adds device tree nodes for the four PWM controllers present
> on tegra114.
Nit: Capitalize Tegra.
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> @@ -150,4 +150,36 @@
> <1 11 0xf08>,
> <1 10 0xf08>;
> };
DT nodes should be sorted in order by reg address, so I think this is in
the wrong place.
> + pwm0: pwm@7000a000 {
> + compatible = "nvidia,tegra20-pwm";
If the HW is 100% backwards-compatible, that should be:
compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
if not:
compatible = "nvidia,tegra114-pwm";
prev parent reply other threads:[~2013-03-11 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 22:30 [PATCH 1/1] ARM: dt: tegra114: add PWM nodes Andrew Chew
[not found] ` <1363041036-26358-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-11 23:30 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513E6903.6060506@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox