From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH v2] ARM: tegra: expose chip ID and revision Date: Tue, 12 Mar 2013 13:45:14 -0600 Message-ID: <513F85CA.2000800@wwwdotorg.org> References: <1363089667-15737-1-git-send-email-dahuang@nvidia.com> <201303121259.18710.arnd@arndb.de> <513F6E2C.1000101@wwwdotorg.org> <201303121910.55141.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201303121910.55141.arnd-r2nGTMty4D4@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Danny Huang , linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, pgaikwad-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/12/2013 01:10 PM, Arnd Bergmann wrote: > On Tuesday 12 March 2013, Stephen Warren wrote: >>> You are dropping the soc_dev on the floor here by just returning. >>> >>> The idea of the soc node is to have all on-soc components be children >>> of that node, so you should instead pass it into of_platform_populate >>> as the parent device. >> >> Tegra DTs don't have a separate node for on-soc vs. off-soc components. >> Wouldn't passing soc_dev into of_platform_populate() make everything a >> child of this soc_dev; is that what we want? > > Yes, we had long discussions about this when the soc infrastructure was > merged. Right now, everything is a child of /sys/devices/platform/, > basically saying that all devices are random stuff that cannot be > probed. Moving it to /sys/devices/soc0 would not make the hierarchy > any deeper but show much clearer which devices are part of the > soc, and which ones are added as anonymous platform devices by code > that does not use DT based probing. Ideally the second category is > empty. OK, that makes sense. Danny, in that case, the initialization of this SoC object should definitely happen inside tegra_init_fuse(), which is called from tegra_init_early(), so that mach-tegra/tegra.c:tegra_dt_init() can call a function in fuse.c to retrieve that SoC object in order to pass it into of_platform_populate().