From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1 v3] ARM: tegra: add PWM nodes to Tegra114 DT
Date: Tue, 12 Mar 2013 17:12:44 -0600 [thread overview]
Message-ID: <513FB66C.2030007@wwwdotorg.org> (raw)
In-Reply-To: <1363124563-24784-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/12/2013 03:42 PM, Andrew Chew wrote:
> This patch adds a device tree node for the four PWM controllers present
> on Tegra114.
> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
> + pwm: pwm {
> + compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
> + reg = <0x7000a000 0x40>;
I notice that the size is 0x100 in previous chips. Which is more correct?
> + #pwm-cells = <2>;
> + clocks = <&tegra_car 17>;
> + status = "disabled";
Previous chips don't disable this module by default. Perhaps they should?
> + };
next prev parent reply other threads:[~2013-03-12 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 21:42 [PATCH 1/1 v3] ARM: tegra: add PWM nodes to Tegra114 DT Andrew Chew
[not found] ` <1363124563-24784-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-12 23:12 ` Stephen Warren [this message]
[not found] ` <513FB66C.2030007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-03-12 23:17 ` Andrew Chew
[not found] ` <643E69AA4436674C8F39DCC2C05F7638629CA517E4-lR+7xdUAJVNDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2013-03-12 23:24 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513FB66C.2030007@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox