From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Andrew Chew <achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2 v4] ARM: tegra: fix the status of PWM nodes
Date: Wed, 13 Mar 2013 10:07:22 -0600 [thread overview]
Message-ID: <5140A43A.4060808@wwwdotorg.org> (raw)
In-Reply-To: <1363131651-13734-2-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 03/12/2013 05:40 PM, Andrew Chew wrote:
> We should be defining the PWM nodes with status as "disabled" in the
> chip-specific dtsi file, since we don't know whether specific boards
> will use the PWM or not. This patch fixes the PWM node status for
> Tegra20 and Tegra30.
> diff --git a/arch/arm/boot/dts/tegra20-medcom-wide.dts b/arch/arm/boot/dts/tegra20-medcom-wide.dts
> + pwm: pwm {
> + status = "okay";
> + }
> +
> backlight {
You don't need to repeat the label ("pwm:") in this file; it's already
defined in tegra20.dtsi.
Also, the node sort order is wrong here; pwm's reg value is before i2c's
reg value (which is the current node immediately before the backlight
node in this file).
I'll fix these issues up when applying the patch since they're easy.
next prev parent reply other threads:[~2013-03-13 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 23:40 [PATCH 1/2 v4] ARM: tegra: add PWM nodes to Tegra114 DT Andrew Chew
[not found] ` <1363131651-13734-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-12 23:40 ` [PATCH 2/2 v4] ARM: tegra: fix the status of PWM nodes Andrew Chew
[not found] ` <1363131651-13734-2-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-03-13 16:07 ` Stephen Warren [this message]
2013-03-13 16:19 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140A43A.4060808@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox