From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 7/9] ARM: davinci: cpuidle: fix wrong enter function Date: Fri, 29 Mar 2013 17:06:05 +0530 Message-ID: <51557CA5.3060208@ti.com> References: <1364553095-25110-1-git-send-email-daniel.lezcano@linaro.org> <1364553095-25110-7-git-send-email-daniel.lezcano@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1364553095-25110-7-git-send-email-daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Lezcano Cc: rjw-KKrjLPT3xs0@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, rnayak-l0cyMroinI0@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org List-Id: linux-tegra@vger.kernel.org On Friday 29 March 2013 04:01 PM, Daniel Lezcano wrote: > The davinci_enter_idle is called from the cpuidle with the > cpuidle_wrap_enter function. This one does the time compution > for entering and exiting the idle function and then we call > again cpuidle_wrap_enter for cpu_do_idle. This is wrong, we > are calling recursively cpuidle_wrap_enter for nothing and > furthermore reenabling the local irq. > > Remove this and replace it by the cpu_do_idle function. > > Signed-off-by: Daniel Lezcano > --- Looks right to me. Acked-by: Santosh Shilimkar