From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Joseph Lo <josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V3 3/3] ARM: tegra: moving the CPU power timer function to PMC driver
Date: Tue, 02 Apr 2013 13:37:58 -0600 [thread overview]
Message-ID: <515B3396.4080206@wwwdotorg.org> (raw)
In-Reply-To: <1364901583-24867-4-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 04/02/2013 05:19 AM, Joseph Lo wrote:
> The CPU power timer set up fucntion was related to PMC register. Now moving
> it to PMC driver. And it also help to clean up the PM related code later.
> diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c
> +void set_power_timers(unsigned long us_on, unsigned long us_off)
> + rate = clk_get_rate(tegra_pclk);
> +
> + if (WARN_ON_ONCE(rate <= 0))
Nit: Since you need to repost the series anyway, I'd prefer to remove
that extra blank line between the assignment to rate, and the if statement.
next prev parent reply other threads:[~2013-04-02 19:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 11:19 [PATCH V3 0/3] ARM: tegra: add clock source for PMC Joseph Lo
[not found] ` <1364901583-24867-1-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-02 11:19 ` [PATCH V3 1/3] ARM: tegra: get PMC clock source from DT Joseph Lo
[not found] ` <1364901583-24867-2-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-02 19:33 ` Stephen Warren
2013-04-02 11:19 ` [PATCH V3 2/3] ARM: dts: tegra: add clock source for PMC Joseph Lo
[not found] ` <1364901583-24867-3-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-02 19:36 ` Stephen Warren
2013-04-02 11:19 ` [PATCH V3 3/3] ARM: tegra: moving the CPU power timer function to PMC driver Joseph Lo
[not found] ` <1364901583-24867-4-git-send-email-josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-04-02 19:37 ` Stephen Warren [this message]
2013-04-02 19:42 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515B3396.4080206@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).