From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [PATCH 8/9] ARM: omap3: cpuidle: enable time keeping Date: Wed, 03 Apr 2013 22:49:03 +0200 Message-ID: <515C95BF.6030103@linaro.org> References: <1364991322-20585-1-git-send-email-daniel.lezcano@linaro.org> <1364991322-20585-8-git-send-email-daniel.lezcano@linaro.org> <87zjxfzetw.fsf@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <87zjxfzetw.fsf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kevin Hilman Cc: rjw-KKrjLPT3xs0@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linaro-kernel-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, rnayak-l0cyMroinI0@public.gmane.org, swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, santosh.shilimkar-l0cyMroinI0@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, deepthi-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 04/03/2013 07:47 PM, Kevin Hilman wrote: > Daniel Lezcano writes: >=20 >> The TIME_VALID flag is specified for the different states but >> the time residency computation is not done, no tk flag, no time >> computation in the idle function. >> >> Set the en_core_tk_irqen flag to activate it. >> >> Signed-off-by: Daniel Lezcano >> Acked-by: Santosh Shilimkar >=20 > Acked-by: Kevin Hilman >=20 > Also, is this a regression fix that also needs to hit v3.9? Yes, I think so. >> --- >> arch/arm/mach-omap2/cpuidle34xx.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2= /cpuidle34xx.c >> index 80392fc..4f67a5b 100644 >> --- a/arch/arm/mach-omap2/cpuidle34xx.c >> +++ b/arch/arm/mach-omap2/cpuidle34xx.c >> @@ -274,8 +274,9 @@ static int omap3_enter_idle_bm(struct cpuidle_de= vice *dev, >> static DEFINE_PER_CPU(struct cpuidle_device, omap3_idle_dev); >> =20 >> static struct cpuidle_driver omap3_idle_driver =3D { >> - .name =3D "omap3_idle", >> - .owner =3D THIS_MODULE, >> + .name =3D "omap3_idle", >> + .owner =3D THIS_MODULE, >> + .en_core_tk_irqen =3D 1, >> .states =3D { >> { >> .enter =3D omap3_enter_idle_bm, --=20 Linaro.org =E2=94=82 Open source software for= ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog