From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prashant Gaikwad Subject: Re: [PATCH v8 10/14] ARM: tegra: Define Tegra114 CAR binding Date: Thu, 4 Apr 2013 12:44:06 +0530 Message-ID: <515D283E.5060209@nvidia.com> References: <1363956029-31873-1-git-send-email-pdeschrijver@nvidia.com> <1363956029-31873-11-git-send-email-pdeschrijver@nvidia.com> <515031E3.40007@nvidia.com> <20130403141916.GS18519@tbergstrom-lnx.Nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130403141916.GS18519@tbergstrom-lnx.Nvidia.com> Sender: linux-doc-owner@vger.kernel.org To: Peter De Schrijver Cc: "linux-arm-kernel@lists.infradead.org" , Grant Likely , Rob Herring , Rob Landley , Stephen Warren , Russell King , Simon Glass , Rhyland Klein , Pritesh Raithatha , Linus Walleij , Hiroshi Doyu , Laxman Dewangan , Andrew Chew , Mike Turquette , Thierry Reding , "devicetree-discuss@lists.ozlabs.org" , "linux-doc@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org On Wednesday 03 April 2013 07:49 PM, Peter De Schrijver wrote: > On Mon, Mar 25, 2013 at 12:15:47PM +0100, Prashant Gaikwad wrote: >> On Friday 22 March 2013 06:09 PM, Peter De Schrijver wrote: >>> The device tree binding models Tegra114 CAR (Clock And Reset) as a single >>> monolithic clock provider. >>> >>> Signed-off-by: Peter De Schrijver >>> --- >> >> >>> + 263 cclk_lp >>> + 264 dfll_ref >>> + 265 dfll_soc >>> + >> Peter, >> >> Please remove following clock IDs from binding. >> >>> +Mux clocks >>> + > ... >>> + 306 clk_out_1_mux > Is at least used by the init list. So we can't remove that? Init list is internal to driver and does not use device tree, so we can keep that ID in enum but remove from DT binding so that we don't have to change the binding later. > > Cheers, > > Peter.