[Patch V4 1/2] mfd: tps65090: Fix enum in header file

[Patch V4 1/2] mfd: tps65090: Fix enum in header file

[Rhyland Klein]

The enum is missing the definition for the first bit, which makes all
the rest off by one. Add definition for the TPS65090_IRQ_INTERRUPT bit
which at 0.

Signed-off-by: Rhyland Klein <rklein@nvidia.com>
---
v4:
 - no changes since v1

 include/linux/mfd/tps65090.h |    1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/mfd/tps65090.h b/include/linux/mfd/tps65090.h
index 998628a..3f43069 100644
--- a/include/linux/mfd/tps65090.h
+++ b/include/linux/mfd/tps65090.h
@@ -27,6 +27,7 @@
 
 /* TPS65090 IRQs */
 enum {
+	TPS65090_IRQ_INTERRUPT,
 	TPS65090_IRQ_VAC_STATUS_CHANGE,
 	TPS65090_IRQ_VSYS_STATUS_CHANGE,
 	TPS65090_IRQ_BAT_STATUS_CHANGE,
-- 
1.7.9.5

[Patch V4 2/2] mfd: tps65090: Add resources for charger

[Rhyland Klein]

Add irq resources to pass to the charger mfd sub dev so
the charger can listen for interrupts.

Signed-off-by: Rhyland Klein <rklein@nvidia.com>
---
v4:
 - Added of_compatible string to resources for tps65090-charger
v3:
 - no changes since v2
v2:
 - no changes since v1

 drivers/mfd/tps65090.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
index 98edb5be..fbd6ee6 100644
--- a/drivers/mfd/tps65090.c
+++ b/drivers/mfd/tps65090.c
@@ -56,12 +56,23 @@
 #define TPS65090_INT2_MASK_OVERLOAD_FET6		6
 #define TPS65090_INT2_MASK_OVERLOAD_FET7		7
 
+static struct resource charger_resources[] = {
+	{
+		.start  = TPS65090_IRQ_VAC_STATUS_CHANGE,
+		.end    = TPS65090_IRQ_VAC_STATUS_CHANGE,
+		.flags  = IORESOURCE_IRQ,
+	}
+};
+
 static struct mfd_cell tps65090s[] = {
 	{
 		.name = "tps65090-pmic",
 	},
 	{
 		.name = "tps65090-charger",
+		.num_resources = ARRAY_SIZE(charger_resources),
+		.resources = &charger_resources[0],
+		.of_compatible = "ti,tps65090-charger",
 	},
 };
 
-- 
1.7.9.5

Re: [Patch V4 2/2] mfd: tps65090: Add resources for charger

[Samuel Ortiz]

Hi Rhyland,

On Thu, Mar 21, 2013 at 04:30:42PM -0400, Rhyland Klein wrote:
> Add irq resources to pass to the charger mfd sub dev so
> the charger can listen for interrupts.
> 
> Signed-off-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> v4:
>  - Added of_compatible string to resources for tps65090-charger
> v3:
>  - no changes since v2
> v2:
>  - no changes since v1
> 
>  drivers/mfd/tps65090.c |   11 +++++++++++
>  1 file changed, 11 insertions(+)
Applied as well, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

Re: [Patch V4 2/2] mfd: tps65090: Add resources for charger

[Rhyland Klein]

On 4/8/2013 12:01 PM, Samuel Ortiz wrote:
> Hi Rhyland,
> 
> On Thu, Mar 21, 2013 at 04:30:42PM -0400, Rhyland Klein wrote:
>> Add irq resources to pass to the charger mfd sub dev so
>> the charger can listen for interrupts.
>>
>> Signed-off-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> v4:
>>  - Added of_compatible string to resources for tps65090-charger
>> v3:
>>  - no changes since v2
>> v2:
>>  - no changes since v1
>>
>>  drivers/mfd/tps65090.c |   11 +++++++++++
>>  1 file changed, 11 insertions(+)
> Applied as well, thanks.
> 
> Cheers,
> Samuel.
> 
It looks like the merged version was not V4 but an earlier one. V4 added
in the of_compatible string for the charger subnode and I don't see that
in the version in linux-next. I guess I'll post a new patch to add that
separately.

-rhyland

-- 
nvpublic

Re: [Patch V4 1/2] mfd: tps65090: Fix enum in header file

[Samuel Ortiz]

Hi Rhyland,

On Thu, Mar 21, 2013 at 04:30:41PM -0400, Rhyland Klein wrote:
> The enum is missing the definition for the first bit, which makes all
> the rest off by one. Add definition for the TPS65090_IRQ_INTERRUPT bit
> which at 0.
> 
> Signed-off-by: Rhyland Klein <rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> v4:
>  - no changes since v1
> 
>  include/linux/mfd/tps65090.h |    1 +
>  1 file changed, 1 insertion(+)
Applied, thanks.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/